Repository navigation
Maple Review Bot / Maple / review
succeeded
Nov 16, 2026 in 3m 24s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. Window arithmetic is exact at both bucket edges and the corpus runs every query with pushdown on and off; only the open steps/values pairing note needs care.
2 notes · tests covered · risk medium · 1/1 new units observable
Runs a panel's range function and by (...) aggregation as one ClickHouse query and rebuilds the evaluator's grid from its per-step values, so a selector's buckets never cross into the isolate. The gates are conservative and the per-window math mirrors the evaluator; the two earlier notes stand.
planPushdownsandbuildPushdownQuerypushrate, the*_over_timefamily andby (...)aggregations into one queryfromPushedreconstructs labels and step timestamps from the pushed rows the way the selector path does- Each stored bucket fans out to the steps whose window holds it, then the window is recombined
- Selector reads now go through
compiledQueryBoundedwith a 24 MB ceiling
Still open from earlier reviews
- 🔵 Note · F3 ·
stepsandvaluesare paired across two unsortedgroupArrays ·packages/query-engine/src/ch/queries/promql.ts:652 - 🔵 Note · F4 ·
MAX_RESPONSE_BYTESrejects selector reads that fit the isolate ·packages/backend/src/services/promql/PromqlQueryService.ts:66
Production impact
Telemetry this change adds and removes (1)
- ➕ span name
PromqlQueryService.readPushdown·packages/backend/src/services/promql/PromqlQueryService.ts:188
What was checked
- Bucket/window containment is exact: bucket
kspans(origin+(k-1)w, origin+kw], soj*s-m < k <= j*s(ch/queries/promql.ts:190) extrapolated,instantPairand the cross-bucket sums matchextrapolatedRate/instantValue/pairTotals(lib/promql/src/engine/window.ts:82)- Group labels are mirrored in SQL and TS, including
job/instance/resource keys (promql/labels.ts:141vslabelValue)
Observability coverage: 1 of 1 changes observable
| Change | Kind | Observable | Evidence |
|---|---|---|---|
PromQL pushdown read (readPushdown → compiledQueryBounded) |
outbound query | yes | Same executor path as compiledQuery (packages/query-engine/src/execution/executor.ts:615); maple.promql.function/maple.promql.aggregation annotate the span at PromqlQueryService.ts:190 |
2564734 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading