Repository navigation
Confidence 6/10 · 1 issue to address
🟡 Confidence 6/10 · needs attention. Open findings from earlier passes survive at this head, chiefly that a warehouse failure answers 503 while the span stays Ok; wire formatting and org scoping are well pinned.
1 warning −1 · 9 notes · tests partial −1 · risk high −1 · 3/4 new units observable −1
Adds a Prometheus-compatible query and discovery API under /v2/metrics/prometheus/api/v1, with Go-format values, Prometheus error envelopes, metrics:read scoping and org-scoped discovery reads. Mergeable once the open unavailable path's span status is settled; the McpOAuthProtocolError from http-graph.ts is untouched by this diff, which only adds a route layer there.
prometheus.http.tsserves query, query_range, series, labels, label values, metadata, buildinfo and exemplarsPromqlQueryServicegainsseries,labelNames,labelValuesandmetadataover catalog and rollupspromqlIdentityValuesQuery/promqlMetadataQuery/promqlAttributeValuesQueryadd org-scoped discovery readsqueryandmatch[]are redacted from the traced request URL
Still open from earlier reviews
- 🟠 Warning · F21 · A warehouse failure answers 503 but leaves the span successful and records no error ·
apps/api/src/routes/v2/prometheus.http.ts:68 - 🔵 Note · F13 ·
prometheusMetadatakeeps the first row per family, so a name's type is arbitrary ·packages/query-engine/src/promql/discovery.ts:96 - 🔵 Note · F14 · The
Date-range edge test asserts only that the status is not 500 ·apps/api/src/routes/v2/prometheus.http.test.ts:307 - 🔵 Note · F16 ·
mergedis never tested with both a query string and a form body ·apps/api/src/routes/v2/prometheus.http.ts:47 - 🔵 Note · F18 ·
/label/le/valuesalways answers empty although/labelslistsle·packages/backend/src/services/promql/PromqlQueryService.ts:518 - 🔵 Note · F19 ·
PrometheusQueryResponseomits thewarningsthe query handlers return ·packages/domain/src/http/v2/prometheus.ts:37 - 🔵 Note · F20 · The year-0 leap-day assertion cannot fail on a wrong instant ·
apps/api/src/routes/v2/prometheus-wire.test.ts:41 - 🔵 Note · F22 · The largest-double pin
/^179769313486231570+$/accepts a short zero run, soshiftPointpadding is unpinned ·apps/api/src/routes/v2/prometheus-wire.test.ts:11 - 🔵 Note · F23 · No discovery test passes
limit, so the dedupe-then-limit fix (limited) is unpinned ·packages/backend/src/services/promql/PromqlQueryService.test.ts:291 - 🔵 Note · F24 ·
metadata'smetricfilter andlimitare untested ·packages/backend/src/services/promql/PromqlQueryService.test.ts:345
Production impact
Open errors in the changed files (1)
| Issue | Service | Occurrences | File |
|---|---|---|---|
| @maple/backend/errors/McpOAuthProtocolError | maple-api | 4 | apps/api/src/runtime/http-graph.ts |
After this merges, Maple checks whether they stop.
Telemetry this change adds and removes (13)
- ➕ span name
PrometheusApi.query·apps/api/src/routes/v2/prometheus.http.ts:118 - ➕ span name
PrometheusApi.queryRange·apps/api/src/routes/v2/prometheus.http.ts:138 - ➕ span name
PrometheusApi.series·apps/api/src/routes/v2/prometheus.http.ts:167 - ➕ span name
PrometheusApi.labels·apps/api/src/routes/v2/prometheus.http.ts:173 - ➕ span name
PrometheusApi.labelValues·apps/api/src/routes/v2/prometheus.http.ts:180 - ➕ span name
PrometheusApi.metadata·apps/api/src/routes/v2/prometheus.http.ts:187 - ➕ span name
PromqlQueryService.series·packages/backend/src/services/promql/PromqlQueryService.ts:355 - ➕ span name
PromqlQueryService.attributeKeys·packages/backend/src/services/promql/PromqlQueryService.ts:391 - ➕ span name
PromqlQueryService.labelNames·packages/backend/src/services/promql/PromqlQueryService.ts:420 - ➕ span name
PromqlQueryService.attributeValues·packages/backend/src/services/promql/PromqlQueryService.ts:436 - ➕ span name
PromqlQueryService.identityValues·packages/backend/src/services/promql/PromqlQueryService.ts:467 - ➕ span name
PromqlQueryService.labelValues·packages/backend/src/services/promql/PromqlQueryService.ts:489 - ➕ span name
PromqlQueryService.metadata·packages/backend/src/services/promql/PromqlQueryService.ts:525
What was checked
- Every new query filters
OrgIdviaorgIdParam(promql.ts:367, 752, 775, 798), and the service test refuses non-single-tenant reads parseTime/parseStepreject out-of-range epochs and rolled-over calendar fields beforeformatWarehouseDateTime(prometheus-wire.ts:48)- Discovery label-marking and identity values reuse
labelValueExpr, so/seriesand/label/job/valuescannot disagree
Observability coverage: 3 of 4 changes observable
| Change | Kind | Observable | Evidence |
|---|---|---|---|
Prometheus query routes (/query, /query_range, GET and form POST) |
HTTP server route | yes | Effect.fn("PrometheusApi.query")/queryRange (prometheus.http.ts:118, 138); server span from the existing API tracing, with query/match[] redacted (api-observability.ts:66-71) |
Prometheus discovery routes (/series, /labels, /label/:name/values, /metadata, /status/buildinfo, /query_exemplars) |
HTTP server route | yes | Effect.fn spans at prometheus.http.ts:167-193 with maple.promql.* attributes |
| Discovery warehouse reads (series, label names, label values, metadata) | database query | yes | warehouse.compiledQuery contexts promqlLabelNames/promqlLabelValues/promqlJobs/promqlInstances/promqlMetadata (PromqlQueryService.ts:400-482) |
| Prometheus error path (warehouse failure → 503) | error path | no | toErrorResponse logs and returns the 503 as a success value (prometheus.http.ts:66-70), so the span stays Ok — open finding F21 |
f4cc0ea · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.