Repository navigation
fix(web): raw SQL tiles without a display type load, trace paging stops at the API's offset cap - #2713
Merged
Maple Review Bot / Maple / review
succeeded
Nov 16, 2026 in 1m 43s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. Both fixes are pinned by new tests, and the production error comes from the exact span the diff relaxes.
no findings · tests covered · risk medium
Relaxes the raw-SQL chart decode so a widget stored without displayType loads, and makes the 2000 offset cap one constant the query schema, listTraces and the trace list all read. Contained to the web client; both fixes are tested.
getRawSqlChartaccepts a missing or unknowndisplayTypeand returns rows as sentMAX_TRACES_LIST_OFFSETin@maple/domain/query-engineis the single offset caplistTracesrejects a deeper offset with a typedWarehouseDecodeErrorisCappedstops paging at the offset cap and the footer says the list was cut short
Fixed since the last review
- ✅
F1 · Trace list stops at the offset cap with no hint that more traces exist
What was checked
- Production
Missing key at ["displayType"](179 events) is raised by theQueryEngine.getRawSqlChartspan the diff relaxes - Reshaping for known types unchanged:
rawSqlRowsForDisplayonly reshapes line/area/bar (raw-sql-chart-rows.ts:80) - With PAGE_SIZE 100 the last offset asked is 2000 ≤ cap, and a failed page at 2000 is still retryable (
update.ts:72,update.ts:166)
bfc7a25 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading