Skip to content

feat(landing): price, retention and setup on every feature page - #2717

Merged
Makisuo merged 3 commits into
mainfrom
t3/feature-page-competitive-review
Nov 16, 2026
Merged

Makisuo merged 3 commits into
mainfrom
t3/feature-page-competitive-review

fix(landing): infer the product event icon map with satisfies

624c519
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 16, 2026 in 34s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. The only delta since the reviewed commit is a two-line type fix in one Astro file, and it type-checks the icon lookup without changing what renders.
no findings · tests covered · risk low

The delta since the last review is a two-line change in ProductEventsSources.astro that replaces the inline icon strings with an ICONS map inferred from PRODUCT_EVENT_SOURCES's labels. The cards still render the same label, title, body, file, snippet and docs link.

  • ProductEventsSources.astro icons come from an ICONS map checked against the source labels
  • Card fields are read from PRODUCT_EVENT_SOURCES, with messages called per render
What was checked
  • git diff 6fb16b2..624c519 touches only ProductEventsSources.astro, 2 insertions
  • title/body thunks are called in the frontmatter, not at module scope (page-registry.ts rule 1)
  • ICONS satisfies Record<label, PixelIconName>, so a missing or unknown icon is a type error

624c519 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.