Skip to content

feat(status-pages): redesign the editor as Live page, Incidents, Maintenance and Settings - #2718

Open
JeremyFunk wants to merge 4 commits into
mainfrom
feat/status-page-editor-v2
Open

JeremyFunk wants to merge 4 commits into
mainfrom
feat/status-page-editor-v2

fix(status-pages): keep component saves and the closing sheet tied to…

8236972
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 16, 2026 in 1m 35s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. The follow-up commit only reworks the editor's component-save state machine and Escape ownership, each pinned by a scene test; the paths I traced hold.
no findings · tests covered · risk medium

The follow-up commit ties each component save to its own component (a tagged ComponentSave plus a per-component queue), keeps a deleted incident in the closing sheet, and narrows Escape to real popups. Safe to merge.

  • ComponentSave is a tagged union keyed by component, so only that row shows it
  • queuedComponentForms sends an edit typed while a save is already in flight
  • sheetIncident keeps a deleted incident's content while the sheet closes
  • popupOwnsEscape lets Escape close an expanded component row
What was checked
  • Popup triggers in the kit all set aria-haspopup beside aria-expanded (dropdown-menu.ts:31, combobox-picker.ts:51), so the narrower Escape keeps menus and pickers
  • Component rows are native button with OnClick (pressable.ts:34-47), so a field's blur commits before the row closes
  • A Supersede re-read keeps the listed rows (keyed.ts:139-142), so a queued form diffs against real components

8236972 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.