Repository navigation
Conversation
Contributor
|
(I replied to (current) open questions on Zulip, #New Members > MDEV-40289 Improve SHOW BINLOG EVENTS @ 💬.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements SHOW BINLOG EVENTS FROM 'gtid' [TO 'gtid'] for the binlog in engine (MDEV-40289).
What works:
FROM <gtid>, as Kristian Nielsen explained in this #New Members > MDEV-40289 Improve SHOW BINLOG EVENTS.TOstops after the given GTID.ER_INCORRECT_GTID_STATE.binlog_in_engine.binlog_events_gtid, including a range that crosses binlog files.Open questions:
mainthe right branch for this feature, or should it go elsewhere?FROM 100 TO 'gtid'do (a byte position mixed with a GTID)?FROM ''be an error? Today it shows all events.'0-1-9,1-1-1'are not covered yet. I am not sure one skip flag for all domains is correct.@@gtid_domain_idvalues, and a copy of the test underbinlog_storage_engine=innodb, as Brandon suggested.