Repository navigation
docs task: Use UTF-8 encoding when opening the documentation generated by libdoc in write mode - #5518
Merged
Merged
Conversation
… in write mode libdoc writes docs/Browser.html as UTF-8. On Windows Python uses cp1252 as standard encoding. Therefore reading the file fails. This PR fixes this issue, thus allowing the docs task to run successfully on Windows. This way inv package can run successfully on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5514 only fixed the issue with opening the file in read-mode. My apologies for overlooking this changed line.