Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #83 +/- ##
========================================
Coverage 99.27% 99.27%
========================================
Files 17 17
Lines 1374 1374
Branches 193 193
========================================
Hits 1364 1364
Misses 5 5
Partials 5 5 🚀 New features to boost your workflow:
|
|
I also fixed the issue with the docs. And removed the warning that qtk in is beta. It feeled weird after 3 years since the first release... |
|
You mean dropping support of 3.10 too ? I agree, to me we can remove it from the test matrix. |
davidwaroquiers
left a comment
There was a problem hiding this comment.
All good to me. For 3.10, I would say you can drop it. One small comment about sphinx design's recommendation also.
I dropped 3.10 in the test matrix. In general in the opening message I was more referring to the code than just the testing. One can probably adjust different things related to typing at least. With an agent should be relatively fast to do, but I think there is not a big advantage at this stage and we can postpone this, so that for the time being qtk keeps the compatibility even with old python versions. I will merge as soon as the checks finish. |
Seems that 3.9 is not found anymore in the test machine.
Here I am just trying to update the matrix for the python versions to test. Since it has been more than one years since 3.9 reach its EOL (and 3.10 also just reached as well), we might want to consider dropping entirely the support in the code.