Repository navigation
fix(agent-core-v2): watch extra skill directories - #4770
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 9992f4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
7Sageer
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirement or Bug
配置
extra_skill_dirs后,运行中的会话需要重新扫描才能发现追加目录里的文件变化。这个修复让新增或修改的技能自动更新到已加载的技能目录。Bug Reproduction Steps
config.toml中配置一个额外技能目录并启动会话。<name>/SKILL.md。Root Cause
额外技能源监听配置项变化。对已配置目录的文件写入没有目录变更通知,因此没有触发已有的按源重扫。
Code Changes
显式目录和额外目录共用已有的配置目录 watcher。文件变化经过防抖后,通过额外技能源的
onDidChange重扫并合并目录。配置切换时,额外技能源释放旧监听并注册新目录。配置清空时释放监听。Behavior Changes and Affected Users
config.toml中设置extra_skill_dirs的用户extra_skill_dirs的用户macOS 和 Windows 11 均用真实
config.toml启动 Core Program 对照验证。基线需要手动重扫,修复后直接写入技能会自动刷新。配置切换后验证旧目录停止产生刷新事件,新目录继续刷新,清空配置后也停止刷新。定向验证
macOS 四组相关测试 69 项通过、1 项跳过。Windows 定向 watcher 用例 5 项通过。Core 类型检查、生产文件 lint 和
git diff --check通过。代码验证提交为2b48d4963。Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.