Repository navigation
Conversation
Member
|
I'll add the fonts files separately as they are cryptic. |
Member
|
I'm going to close this and go a different route. What I didn't know until I got this PR was that Hershey fonts don't do Mandarin or Hangul (which I wanted a new draw procedure to do) and that FFMPEG has the ability to implement this for installed true type fonts and easily manages various sizes, colors, FreeType flags, etc. I've been able to prototype the FFMPEG implementation today so I'll be trying to fully implement it over the next week or so. Please note that I do appreciate your work to create the PR. I just think that using the FFMPEG option with the FreeType backend will provide a better overall experience for users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include text rendering code, a set of fonts and minimal configuration changes.
At runtime fonts are expected to be in a fonts folder relative to the config_dir or use the HERSHEY_FONTS_DIR environment variable.
In order to create a minimal set of changes I have not compiled these changes on this fork!