Repository navigation
Fix Teams preinstallation, allowlists, and scheduled delivery - #76
Open
JeffPengCoder wants to merge 2 commits into
Open
JeffPengCoder wants to merge 2 commits into
JeffPengCoder wants to merge 2 commits into
Conversation
Signed-off-by: Jeff Peng <jepeng@nvidia.com>
JeffPengCoder
requested review from
RohanAdwankar and
kgengedullay
as code owners
October 29, 2026 06:31
4 tasks done
This was referenced Oct 30, 2026
Signed-off-by: Jeff Peng <jepeng@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #71, targeting its source branch so the author can merge these fixes into the existing PR.
The documented scheduled Teams delivery cannot run while the generated OpenClaw configuration hard-codes
cron.enabled=false. The allowlist validator also accepts['*']and blank entries despite requiring Entra object IDs; the pinned runtime treats*as a wildcard. This change makes cron an explicit opt-in and validates concrete user GUIDs and nonempty Secret key names.Add
openclaw.msteams.install=truefor credential-free plugin preparation on the existing PVC. Messaging stays disabled, no bot Secret is referenced, and no Teams listener or ingress is exposed untilenabled=true. Existing enabled configurations continue to install the plugin automatically.The installation guide now explains tenant-side prerequisites, the Microsoft developer CLI, public HTTPS routing, conversation initialization, scheduler activation, and the difference between component health and real Teams delivery. The generated agent documentation bundle is refreshed.
Validation
git diff --checkpassed.For the pinned plugin used by #71, ARM64 kind checks also verified installation/loading, configuration validation, an unsigned webhook request returning 401 on port 3978, Gateway health returning 200, and loading after recreating a persistent OpenClaw Pod. The additional follow-up behavior is covered by the chart tests above. Authenticated tenant DM round trips, proactive delivery, and phone notifications still require real tenant acceptance testing.
Checklist
Follow-up diagnostic code (2026-11-04)
Commit
3deea66aab4a09973af1602b4f8c14f9c4037bf1adds a portable one-shot Graph delegated diagnostic. This is a separate diagnostic route; it does not turn the native Bot channel into a delegated user channel or change existing Bot credentials. This follow-up changes code/tests only.--sendand a distinct recipient Entra GUID; chat members use concrete GUID bindings.Validation: full suite 229 tests, 227 passed, 2 existing skips, 0 failed; focused Node tests 9/9 and Python runner tests 9/9; standalone inference 4/4; Helm lint, documentation-bundle check and
git diff --checkpassed. A real isolated identity probe using the new runner completed token acquisition and Graph/mewith HTTP 200 and removed all three temporary resources. No chat was created and no Teams message was sent. The separate delegated chat consent and full Teams round-trip remain unvalidated.