Repository navigation
fix(diagnostic-policy): allow -s, -d, and -t flags for lspci bridge inspection - #92
Merged
RohanAdwankar merged 1 commit intoNov 3, 2026
Conversation
…nspection - Allow -s <slot>, -d <device>, and -t flags in diagnostic lspci policy for GPU networking investigations - Add unit tests verifying valid and rejected lspci arguments Signed-off-by: dev-akshatshukla <akshat21shukla@gmail.com>
Akshatshukla-25
requested review from
RohanAdwankar and
kgengedullay
as code owners
November 3, 2026 04:05
RohanAdwankar
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #69
The diagnostic command policy previously restricted
lspciwith regex/^(-[Dknmvx]+|-[a-zA-Z]{2,})$/. This rejected parameters with option values like-s <slot>and-d <device>, as well as tree-view-t.This blocked standard PCIe ancestor bridge inspections recommended by the
gpu-networkingskill (lspci -s <bridge> -vvv), preventing agents from reading slot-specific device capabilities in View mode.Changes
lspcivalidator indiagnostic-policy.tspermitting-s <slot>,-d <device>,-t, and standard output flags (-D,-k,-n,-m,-v,-x,-b).-s <slot>) and attached (-s<slot>) parameter formats.diagnostic-policy.test.mjsverifying accepted and rejected edge cases.Checklist