Repository navigation
Conversation
Clients name their topics in the handshake (auth.topics) or with
set_subscriptions (acked with {"count": n}) and get only those; clients
that never do stay on the every-topic room. Unread topics are skipped
before serialization. ADR 0009 records the decision.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013vbA3j9hMDhLiYyTkHLpH8
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Collaborator
Author
|
Superseded by #1010 (branch renamed to 993-socket-io-rooms, co-author added). Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
scylla-server sends each data message only to sockets in its topic's Socket.IO room. A client subscribes with a set_subscriptions event (full list, acked with a count) or in the connect handshake's auth topics; once it has, it never gets every topic again. Clients that never subscribe stay on an every-topic room, so older clients keep working. Topics nobody reads are skipped before serializing. ADR 0009 records the decision.
Diagram
Testing
Notes
Checklist
Closes #993
Generated by Claude Code