Repository navigation
Conversation
Each topic-tree leaf row renders a topic-live-value that subscribes to its topic while it exists; Angular Aria renders a tree group only while its parent is expanded, so collapsed branches hold no subscriptions. The tree build no longer creates a toSignal per leaf. Storage replays each topic's latest value to new subscribers, so a row shown on expand starts from it; the map's live trace skips that replay (as in #994), since after a run change it is the last run's fix. Flat mode still renders, and so subscribes, every leaf. Ported from #987's spike (ead2873). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vbA3j9hMDhLiYyTkHLpH8
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Collaborator
Author
|
Superseded by #1012 (branch renamed to 996-sidebar-rendered-row-values, stacked on #1008, co-author added). Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Stacked on #1002. Each sidebar leaf row renders a live-value component that subscribes to its topic only while the row is rendered; the tree build no longer subscribes per leaf. Storage replays each topic's latest value, so an expanded row shows it at once. Angular Aria already destroys collapsed groups.
Testing
Screenshots
Taken locally, not attached.
Notes
Checklist
Closes #996
Generated by Claude Code