Skip to content

Create graph sidebar live values only for rendered rows - #1006

Closed
bracyw wants to merge 1 commit into
992-render-only-one-graph-sidebarfrom
996-create-graph-sidebar-live-values-only-for-rendered-rows
Closed

bracyw wants to merge 1 commit into
992-render-only-one-graph-sidebarfrom
996-create-graph-sidebar-live-values-only-for-rendered-rows

Conversation

@bracyw

@bracyw bracyw commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Changes

Stacked on #1002. Each sidebar leaf row renders a live-value component that subscribes to its topic only while the row is rendered; the tree build no longer subscribes per leaf. Storage replays each topic's latest value, so an expanded row shows it at once. Angular Aria already destroys collapsed groups.

Testing

  • Specs for storage replay, the row component, the tree build, and a sidebar spec pinning Aria destroying collapsed groups
  • In the running app (Chromium): with the tree collapsed, graph-page subscriptions went from 1,855 to 721; expanding a branch added 14 and showed values within a frame, collapsing released them

Screenshots

Taken locally, not attached.

Notes

Checklist

  • Commits are tagged with the ticket number
  • Lint, format and tests pass
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots)
  • No package-lock.json changes unless dependencies changed
  • Request reviewers & ping on Slack

Closes #996


Generated by Claude Code

Each topic-tree leaf row renders a topic-live-value that subscribes to its
topic while it exists; Angular Aria renders a tree group only while its parent
is expanded, so collapsed branches hold no subscriptions. The tree build no
longer creates a toSignal per leaf. Storage replays each topic's latest value
to new subscribers, so a row shown on expand starts from it; the map's live
trace skips that replay (as in #994), since after a run change it is the last
run's fix. Flat mode still renders, and so subscribes, every leaf.

Ported from #987's spike (ead2873).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013vbA3j9hMDhLiYyTkHLpH8
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 38686a07-43ca-4ef0-a3de-9cd1c3af1781

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@bracyw bracyw added frontend Development Focused in the Frontend by: ai Written by AI dev work Implementation work: feature, bug, or task labels Nov 20, 2026 — with Claude

bracyw commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #1012 (branch renamed to 996-sidebar-rendered-row-values, stacked on #1008, co-author added).


Generated by Claude Code

@bracyw bracyw closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

by: ai Written by AI dev work Implementation work: feature, bug, or task frontend Development Focused in the Frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants