Skip to content

Subscribe BMS cell topics only while a page shows them - #1007

Closed
bracyw wants to merge 1 commit into
994-subscribe-each-client-only-to-the-topics-its-page-readsfrom
995-release-bms-cell-topics-when-no-page-shows-them
Closed

bracyw wants to merge 1 commit into
994-subscribe-each-client-only-to-the-topics-its-page-readsfrom
995-release-bms-cell-topics-when-no-page-shows-them

Conversation

@bracyw

@bracyw bracyw commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Changes

Stacked on #1005. CellService no longer subscribes to the ~720 BMS cell topics app-wide at startup. Components that show cell data hold them through a retain/release pair: the segment heatmap while it exists, and the Cell Comparison panel while it's open (it's an overlay that can outlive the BMS pages). On the last release, readings are cleared so nothing shows stale values.

Testing

  • New CellService spec (8 tests) plus heatmap and cell-view spec additions
  • In the running app (Chromium): the map page reads 2 topics; a BMS page 751, 721 of them cell topics; back on the map, the cell topics are held through the 2.5 s linger, then released

Screenshots

Taken locally, not attached.

Notes

  • The segment page wasn't checked live; its heatmap uses the same code.

Checklist

  • Commits are tagged with the ticket number
  • Lint, format and tests pass
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots)
  • No package-lock.json changes unless dependencies changed
  • Request reviewers & ping on Slack

Closes #995


Generated by Claude Code

…hows them

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013vbA3j9hMDhLiYyTkHLpH8
@bracyw bracyw added frontend Development Focused in the Frontend by: ai Written by AI dev work Implementation work: feature, bug, or task labels Nov 20, 2026 — with Claude
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6ad6c2e8-17af-49e5-906c-0d20fed4de4d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

bracyw commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #1013 (branch renamed to 995-release-bms-cell-topics, stacked on #1011, co-author added).


Generated by Claude Code

@bracyw bracyw closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

by: ai Written by AI dev work Implementation work: feature, bug, or task frontend Development Focused in the Frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants