Skip to content

Ignore screencast frames that arrive after a demo recording stops - #105

Draft
bracyw wants to merge 1 commit into
mainfrom
104-ignore-late-screencast-frames
Draft

bracyw wants to merge 1 commit into
mainfrom
104-ignore-late-screencast-frames

Conversation

@bracyw

@bracyw bracyw commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Changes

When a demo recording stops, a screencast frame already in flight could still arrive and start writing after the frames folder was removed. The video was written, but the run then exited with ENOENT. The screencast now ignores frames that arrive after the stop.

Testing

  • Recorded the Argos epic #991 demos with --video on the BMS page: the late-frame crash stopped, and the videos are unchanged
  • ci/check.sh passes. tests/e2e.sh fails one check ("sync after adding workspace-inherit/") on macOS, the same way on unchanged main (BSD awk), so it is unrelated

Checklist

  • ci/check.sh passes
  • Version bumped if a .delphi/manifest.yml file changed (none changed)
  • No merge conflicts
  • Request reviewers & ping on Slack

Closes #104

@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0e44d9b4-079e-45da-820d-a3b898df73ec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore screencast frames that arrive after a demo recording stops

1 participant