[hbrunn]

depends on:

• [20.0] initialize branch #6045

[hbrunn]

pre-commit failure fixed in OCA/pylint-odoo#590

[FerDeNetlab]

Tested on a 19.0 db with crm, sale_management, purchase, stock, account + l10n_mx, project, hr, mrp and point_of_sale (131 modules after the upgrade). These are the framework issues we hit, one per comment so you can take what makes sense.

Drafted with AI assistance (Claude Opus 5.5), reviewed by me; each suggestion was checked against the current code of this PR and our test migration.

[FerDeNetlab]

For the patch below.

Suggested change

	from odoo import models
	from odoo import api, models

[FerDeNetlab]

v20 added IrModel._unlink_related_attachments, an ondelete(at_uninstall=False) that deletes all ir.attachment rows of the model, including attachment=True binary fields, and marks their files for GC. registry.uninstalling_modules is still empty when _process_end runs, so it fires for every obsolete model while _drop_table keeps the table.

Suggested change

	IrModel._drop_table = _drop_table
	IrModel._drop_table = _drop_table
	@api.ondelete(at_uninstall=False)
	def _unlink_related_attachments(self):
	"""Never delete attachments (incl. binary field data) of removed models"""
	for model in self:
	openupgrade.message(
	self.env.cr,
	self.env.context.get("module", "Unknown"),
	False,
	False,
	"Not deleting the attachments of model %s",
	model.model,
	)
	IrModel._unlink_related_attachments = _unlink_related_attachments

[FerDeNetlab]

button_install skips auto_install modules whose country_ids don't match any company, this loop doesn't, so e.g. account_peppol gets installed on databases without a Peppol country.

Suggested change

	new_auto_install_modules = self.browse([])
	for module in self.env["ir.module.module"].search(
	[
	("auto_install", "=", True),
	("state", "=", "uninstalled"),
	("name", "not like", ("l10n_%")),
	]
	):
	new_auto_install_modules = self.browse([])
	company_countries = self.env["res.company"].sudo().search([]).country_id
	for module in self.env["ir.module.module"].search(
	[
	("auto_install", "=", True),
	("state", "=", "uninstalled"),
	("name", "not like", ("l10n_%")),
	]
	):
	# same rule as button_install
	if module.country_ids and not module.country_ids & company_countries:
	continue

[FerDeNetlab]

Two things here:

• _validate_module_views and create() call _check_xml on several views, so self.xml_id in the handler raises Expected singleton and aborts the upgrade instead of logging.
• As _raise_view_error doesn't raise anymore, validation goes on and fails later with AttributeError/KeyError/NameError/ValueError (_check_field_paths, _validate_domain_identifiers).

Suggested change

	try:
	return IrUiView._check_xml._original_method(self)
	except ValidationError as e:
	_logger.warning(
	"Can't render custom view %s for model %s. "
	"Assuming you are migrating between major versions of Odoo. "
	"Please review the view contents manually after the migration.\n"
	"Error: %s",
	self.xml_id,
	self.model,
	e,
	)
	for view in self:
	try:
	IrUiView._check_xml._original_method(view)
	# with _raise_view_error not raising, validation can fail later on
	except (
	ValidationError,
	ValueError,
	AttributeError,
	KeyError,
	NameError,
	) as e:
	_logger.warning(
	"Can't render custom view %s for model %s. "
	"Assuming you are migrating between major versions of Odoo. "
	"Please review the view contents manually after the migration.\n"
	"Error: %s",
	view.xml_id,
	view.model,
	e,
	)

[FerDeNetlab]

Not needed with the change below.

Suggested change

from uuid import uuid4

[FerDeNetlab]

str(uuid4) is the repr of the function, so every call uses the same savepoint name, and the savepoint is never released after a successful unlink. cr.savepoint() also resets the ORM caches on rollback.

Suggested change

	savepoint = str(uuid4)
	try:
	self.env.cr.execute( # pylint: disable=sql-injection
	f'SAVEPOINT "{savepoint}"'
	)
	return BaseModel.unlink._original_method(self)
	except Exception as e:
	self.env.cr.execute( # pylint: disable=sql-injection
	f'ROLLBACK TO SAVEPOINT "{savepoint}"'
	)
	try:
	with self.env.cr.savepoint():
	return BaseModel.unlink._original_method(self)
	except Exception as e: