[sergio-teruel]

When a record with an XML ID is created, Odoo also creates the XML ID <xmlid>_<parent model> of its _inherits parent, but crons created by old versions lack the one of their server action. This happens on databases started in 10.0 or earlier, whose crons got their server action in the 11.0 migration.

18.0 is the first version whose data references them (stock.ir_cron_scheduler_action_ir_actions_server in the stock and mrp procurement menus), so updating stock fails with "External ID not found in the system: stock.ir_cron_scheduler_action_ir_actions_server".

Reloading the cron data can't fix it, as the parent XML ID is only added when the record is created, not when an existing one is updated, so the missing XML IDs are added from the cron ones with add_xmlid.

@Tecnativa

ping @carlosdauden @carlos-lopez-tecnativa @CarlosRoca13

[carlos-lopez-tecnativa]

Just out of curiosity, from which Odoo version did you migrate? I reviewed a database created in v13, and it already has the XML IDs for ir.cron and ir.actions.server, so I'm not sure whether this code should target a lower branch.

[sergio-teruel]

Good point!!.
The database was created in 10.0 (June 2017). Crons only inherit from ir.actions.server since 11.0, and the 11.0 base migration creates the server actions of the existing crons with a plain INSERT (fill_cron_action_server_post), so they never got the _ir_actions_server XML ID.
In my database exactly the 11 crons created between 2017-06 and 2018-11 lack it, while the ones created later have it, so a database created in 13.0 isn't affected.

I'd still keep the fix in 18.0: 18.0 is the first version whose data references these XML IDs (the stock and mrp procurement menus), so the missing ones are harmless before, and fixing it in 11.0 wouldn't help databases that already went through it.

[sergio-teruel]

I have updated de PR description

[hbrunn]

as this is a quite generic problem, I'd like to see a function in openupgradelib that handles this in a generic way

[sergio-teruel]

PR to openupgradelib done: OCA/openupgradelib#476
After merge it I will change this PR to use the method

[sergio-teruel]

This PR (OCA/openupgradelib#476) has been merged so now we can use the method add_inherits_parent_xmlids.

PR updated

[carlos-lopez-tecnativa]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-6057-by-carlos-lopez-tecnativa-bump-nobump, awaiting test results.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[OCA-git-bot]

Congratulations, your PR was merged at a393ddb. Thanks a lot for contributing to OCA. ❤️