Repository navigation
Updates and bug fixes - #15
Merged
Merged
Conversation
- Bumped package version from 1.9.1 to 1.10.0 in DESCRIPTION. - Updated autocomplete functionality to call the canonical `/search/autocomplete` endpoint, returning compact suggestion fields. - Improved basic search validation to enforce a 3-500 character query length. - Adjusted documentation and tests to reflect these changes, ensuring clarity and consistency in parameter usage.
- Updated the `concept_ids`, `relationship_types`, `vocabulary_ids`, and `domain_ids` in the API to preserve JSON array structure by using unname and as.list. - Modified tests to reflect these changes, ensuring that the body of requests maintains the correct format for concept recommendations. - Added `httpuv` as a suggested dependency in DESCRIPTION. - Documented improvements in NEWS.md regarding JSON array preservation for various filters.
Fix concept-code lookups containing slashes
Enhance JSON handling in concepts API and update tests
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 23 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes several correctness bugs in the
omophubR client and bumps the package to 1.10.0.Bug Fixes
get_by_code()percent-encodes vocabulary and code path segments, so codes containing slashes or percent signs work with all query options.omophub_*condition classes (omophub_validation_error,omophub_auth_error,omophub_forbidden_error,omophub_not_found,omophub_rate_limit_error,omophub_server_error,omophub_connection_error), carryingstatus_code,error_code,details,request_id, andretry_after; the httr2 classes ande$respare preserved for existing handlers. Unparseable or empty error bodies fall back to the HTTP status without masking the failure.Changed
/search/autocompleteand returns compactsuggestion,type, andcountfields; basic search enforces the API's 3–500 character query range.integration-tests.yaml.Written for commit 966ac15. Summary will update on new commits.