Skip to content

#15214: Fix CSV summary import categories and LGR address parsing - #15215

Merged
magnesj merged 3 commits into
devfrom
bugfix-lgr-summary-address
Nov 21, 2026
Merged

magnesj merged 3 commits into
devfrom
bugfix-lgr-summary-address

Conversation

@magnesj

@magnesj magnesj commented Nov 20, 2026

Copy link
Copy Markdown
Member

Fixes #15214

CSV summary import categorised FOPT_Exp and FOPT_Low as Field but FOPT_High and FOPT_Base as Imported, because summary vector names must be 3-8 characters to be recognised.

Changes

  • Fix an out-of-bounds read when parsing LGR well connection addresses (LCGAS:LGR1:B-1H without IJK); the guard checked for more than two tokens but read tokens[3].
  • Skip the keyword length rule when parsing CSV column headers, so FOPT_High and FOPT_Base map to Field like FOPT_Exp. Free text with whitespace (e.g. formation index) is still imported.
  • Move fromEclipseTextAddress, fromEclipseTextAddressParseErrorTokens and fromTokens from RifEclipseSummaryAddress into the new RifEclipseSummaryAddressParser. No behavior change.

Unit tests are added for each fix. Best reviewed commit by commit.

The SUMMARY_WELL_CONNECTION_LGR case checked for more than two tokens but read tokens[3]. Require four tokens, and add tests for the full and truncated forms.
…ector category

Skip the 3-8 character keyword length rule when parsing CSV column headers so names like FOPT_High are categorised like FOPT_Exp. Free text containing whitespace is still imported.
@magnesj
magnesj requested a review from jonjenssen November 20, 2026 06:32
@magnesj magnesj self-assigned this Nov 20, 2026
…Parser

Extract fromEclipseTextAddress, fromEclipseTextAddressParseErrorTokens and fromTokens out of RifEclipseSummaryAddress. No behavior change.
@magnesj
magnesj force-pushed the bugfix-lgr-summary-address branch from 447d61e to ca35f7d Compare November 21, 2026 12:49
@magnesj
magnesj merged commit 1eee3f4 into dev Nov 21, 2026
23 of 25 checks passed
@magnesj
magnesj deleted the bugfix-lgr-summary-address branch November 21, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSV summary import: columns with long custom suffix are imported as Imported instead of Field

2 participants