Repository navigation
Pin CMake 4.4.0 on Ubuntu 26.04 CI to fix boost-locale build - #15232
Merged
Merged
Conversation
CMake 4.5 on the ubuntu-26.04 runner image rejects the source_group(TREE) call in Boost.Locale <= 1.91. Pin CMake until a Boost release includes the upstream fix.
vcpkg requires CMake >= 4.4.0 and ignored 3.31.6 on PATH, falling back to the system CMake 4.5. CMake 4.4 still uses a string-prefix check in source_group(TREE), which Boost.Locale passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ubuntu 26.04 job in ResInsight Build With Cache fails in the Configure step (e.g. run 44848316788) because vcpkg cannot build
boost-locale:Cause
source_group(TREE …)checks whether the root is a path prefix of each file (cmCMakePath::IsPrefix). CMake 4.4 and older only checked whether the strings share a prefix (cmHasPrefix).include/boost/locale.hpppasses the string check against the rootinclude/boost/localebut fails the path check.boostorg/localedevelop, but no release includes the fix yet.Fix
Install CMake 4.4.0 with
jwlawson/actions-setup-cmake(pinned to a commit SHA) for theubuntu-26.04job only.The first commit pinned 3.31.6, which did not work: vcpkg requires CMake >= 4.4.0 (
scripts/vcpkg-tools.json), so it skipped 3.31.6 on PATH and used the system/usr/local/bin/cmake4.5.0. Version 4.4.0 meets vcpkg's minimum and still uses the old prefix check.Remove the step once a Boost release includes the fix.
🤖 Generated with Claude Code