Repository navigation
refactor(runtime): clear the Sonar findings in internal/exec/runtime - #1606
Merged
Merged
Conversation
Split evalFeatureChain, recordedOccurrences and bindingWitnesses into named helpers, pass the binding site of a calc invocation as one value, take the connector fill's own undo instead of a placeholder closure, name the journal nothing opened, and tidy four tests (opposite operator, a shadowed copy, two counts now reported). Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: jason.han <hanhuijun@gmail.com>
6 tasks done
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Clears the 13 open SonarCloud findings under
internal/exec/runtimeondevelop, each at the root rather than by suppression. Behaviour is unchanged: every edit is a split into named helpers, a renamed variable, or a message that now reports the value it compares.eval.go:1572evalFeatureChainenactedConstraintChain,occurrenceChainValue,valuelessChain,operandChainValue; the order of the reads is unchanged.held_image.go:1091recordedOccurrencesmade/madeAllclosures becamemadeID/madeIDsmethods; start values and transfers are carried bycarriedStartValuesandcarriedTransfer.subsetting.go:1113bindingWitnessesdrawBindingWitnessesover awitnessDraw(pool, taken, chosen, seen) whosepickdraws the linked count.connector.go:87undoFills := func() {}is gone — the fill runs first andfailcloses over the undo it returns (which is never nil).connector.go:368noJournal()whose body says why there is nothing to commit, undo or drain.namespace_binding.go:676noJournal().invoke_calc.go:933bindCalcParametersnested,occurrence,open) are onecalcBindingSitevalue; five call sites updated.robustness_loop_performances_test.go:94!(a <= b)→a > b.robustness_value_stand_in_test.go:182copy→replica.binding_connector_multiplicity_test.go:39gotis now reported in the failure message.shape_items_limits_test.go:53No dispositions, nothing deferred.
How it was verified
go build ./...,go vet ./internal/exec/runtime/...,gofmt -lempty.go test -count=1 -timeout 60m ./internal/exec/runtime/...green (one pilot-corpus gate re-run green after the corpora were provided to the worktree);./internal/exec/... ./tests/corpus ./tests/grpcrun as consumers.gocognit -over 30on the three files: none of the three functions remains over 30.analyze_code_snippeton each changed file: thedevelopcopies report exactly the findings above; the branch copies report none of them (the remaining hits are findings already resolved ondevelop).Overlap with open PRs
fix/namespace-read-multiplicity) also editseval.go, inconformHeld(around line 1333); this PR's hunks are inevalFeatureChain(1572+). Textually clean; either order.origin/develop(12e4fc3): this head (9ed7ce5), then fix(runtime): hold a namespace-level feature read in its effective multiplicity #1585 (a7c0cf4) — merges clean,go build ./...,go vet ./internal/exec/runtime/...and the runtime conformance/robustness/chain tests pass on the merged tree.perf/*PR touchesinternal/exec/runtime,internal/semanticorinternal/frontend/lspat this time (open PRs re-listed before leaving draft). refactor(symbols): drop the unexported duplicate of UsageSymbolKind #1613 (refactor/usage-symbol-kind-dedup, 50db66b,internal/semantic/symbols) does not touch this PR's files.go build ./...,go vet ./...andgofmt -lclean on the combined tree.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.md— not needed: refactor only, no behaviour changemake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build) — no count movedF4,K5) in the body, docs, or changelogRequested by: @HuiJun