Skip to content

fix(typescript-...): Fix basic auth without username or password #25462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coffeemakr wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(typescript-...): Fix basic auth without username or password #25462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc03a0a
[typescript]: Fix basic auth without username or password
coffeemakr Oct 29, 2026
e0b0f57
[typescript-inversify]: Add 'Basic ' prefix to authorization header
coffeemakr Oct 29, 2026
bd78791
[javascript]: Add more fixes
coffeemakr Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/Javascript-Apollo/ApiClient.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export default class ApiClient extends RESTDataSource {
switch (auth.type) {
case 'basic':
if (auth.username || auth.password) {
fetchOptions.headers['Authorization'] = 'Basic ' + base64.encode(auth.username + ":" + auth.password);
fetchOptions.headers['Authorization'] = 'Basic ' + base64.encode((auth.username || "") + ":" + (auth.password || ""));
}

break;
Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/Javascript-Flowtyped/api.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export const {{classname}}FetchParamCreator = function (configuration?: Configur
{{#isBasicBasic}}
// http basic authentication required
if (configuration && (configuration.username || configuration.password)) {
localVarHeaderParameter["Authorization"] = "Basic " + btoa(configuration.username + ":" + configuration.password);
localVarHeaderParameter["Authorization"] = "Basic " + btoa((configuration.username || "") + ":" + (configuration.password || ""));
}
{{/isBasicBasic}}
{{#isOAuth}}
Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/Javascript/libraries/apollo/ApiClient.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export default class ApiClient extends RESTDataSource {
switch (auth.type) {
case 'basic':
if (auth.username || auth.password) {
fetchOptions.headers['Authorization'] = 'Basic ' + base64.encode(auth.username + ":" + auth.password);
fetchOptions.headers['Authorization'] = 'Basic ' + base64.encode((auth.username || "") + ":" + (auth.password || ""));
}

break;
Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/typescript-angular/configuration.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ constructor({ accessToken, apiKeys, basePath, credentials, encodeParam, encoder,
{{#isBasicBasic}}
this.credentials['{{name}}'] = () => {
return (this.username || this.password)
? btoa(this.username + ':' + this.password)
? btoa((this.username || '') + ':' + (this.password || ''))
: undefined;
};
{{/isBasicBasic}}
Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/typescript-fetch/apis.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ export class {{classname}} extends runtime.BaseAPI {
{{#isBasic}}
{{#isBasicBasic}}
if (this.configuration && (this.configuration.username !== undefined || this.configuration.password !== undefined)) {
headerParameters["Authorization"] = "Basic " + btoa(this.configuration.username + ":" + this.configuration.password);
headerParameters["Authorization"] = "Basic " + btoa((this.configuration.username || "") + ":" + (this.configuration.password || ""));
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
}
{{/isBasicBasic}}
{{#isBasicBearer}}
Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/typescript-inversify/api.service.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export class {{classname}} {
{{/isApiKey}}
{{#isBasicBasic}}
if (this.APIConfiguration.username || this.APIConfiguration.password) {
headers['Authorization'] = btoa(this.APIConfiguration.username + ':' + this.APIConfiguration.password);
headers['Authorization'] = 'Basic ' + btoa((this.APIConfiguration.username || '') + ':' + (this.APIConfiguration.password || ''));
}
{{/isBasicBasic}}
{{#isOAuth}}
Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/typescript-jquery/api.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export class {{classname}} {
{{#isBasicBasic}}
// http basic authentication required
if (this.configuration.username || this.configuration.password) {
headerParams['Authorization'] = 'Basic ' + btoa(this.configuration.username + ':' + this.configuration.password);
headerParams['Authorization'] = 'Basic ' + btoa((this.configuration.username || '') + ':' + (this.configuration.password || ''));
}

{{/isBasicBasic}}
Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/typescript-nestjs/api.service.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export class {{classname}} {
{{/isApiKey}}
{{#isBasicBasic}}
if (this.configuration.username || this.configuration.password) {
headers['Authorization'] = 'Basic ' + btoa(this.configuration.username + ':' + this.configuration.password);
headers['Authorization'] = 'Basic ' + btoa((this.configuration.username || '') + ':' + (this.configuration.password || ''));
}

{{/isBasicBasic}}
Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/typescript-playwright/apis.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export class {{classname}} extends runtime.BaseAPI {
{{#isBasic}}
{{#isBasicBasic}}
if (this.configuration && (this.configuration.username !== undefined || this.configuration.password !== undefined)) {
headerParameters["Authorization"] = "Basic " + btoa(this.configuration.username + ":" + this.configuration.password);
headerParameters["Authorization"] = "Basic " + btoa((this.configuration.username || "") + ":" + (this.configuration.password || ""));
}
{{/isBasicBasic}}
{{#isBasicBearer}}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/javascript-apollo/src/ApiClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export default class ApiClient extends RESTDataSource {
switch (auth.type) {
case 'basic':
if (auth.username || auth.password) {
fetchOptions.headers['Authorization'] = 'Basic ' + base64.encode(auth.username + ":" + auth.password);
fetchOptions.headers['Authorization'] = 'Basic ' + base64.encode((auth.username || "") + ":" + (auth.password || ""));

@cubic-dev-ai cubic-dev-ai Bot Oct 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: base64 is never imported or declared in this file, so base64.encode(...) throws a ReferenceError whenever basic auth credentials are set. This line predates the PR, but the PR now edits it and keeps the broken call. Use Node's Buffer instead, which needs no import.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At samples/client/petstore/javascript-apollo/src/ApiClient.js, line 151:

<comment>`base64` is never imported or declared in this file, so `base64.encode(...)` throws a ReferenceError whenever basic auth credentials are set. This line predates the PR, but the PR now edits it and keeps the broken call. Use Node's `Buffer` instead, which needs no import.</comment>

<file context>
@@ -148,7 +148,7 @@ export default class ApiClient extends RESTDataSource {
                 case 'basic':
                     if (auth.username || auth.password) {
-                        fetchOptions.headers['Authorization'] = 'Basic ' + base64.encode(auth.username + ":" + auth.password);
+                        fetchOptions.headers['Authorization'] = 'Basic ' + base64.encode((auth.username || "") + ":" + (auth.password || ""));
                     }
 
</file context>
Suggested change
fetchOptions.headers['Authorization'] = 'Basic ' + base64.encode((auth.username || "") + ":" + (auth.password || ""));
fetchOptions.headers['Authorization'] = 'Basic ' + Buffer.from((auth.username || "") + ":" + (auth.password || "")).toString('base64');

@coffeemakr coffeemakr Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with apollo, so I would change only the default to an empty string.

@coffeemakr coffeemakr Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erithmetic

}

break;
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/default-v3.0/apis/FakeApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,7 @@ export class FakeApi extends runtime.BaseAPI {
const headerParameters: runtime.HTTPHeaders = {};

if (this.configuration && (this.configuration.username !== undefined || this.configuration.password !== undefined)) {
headerParameters["Authorization"] = "Basic " + btoa(this.configuration.username + ":" + this.configuration.password);
headerParameters["Authorization"] = "Basic " + btoa((this.configuration.username || "") + ":" + (this.configuration.password || ""));
}
const consumes: runtime.Consume[] = [
{ contentType: 'application/x-www-form-urlencoded' },
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/kebab-case/apis/fake-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,7 @@ export class FakeApi extends runtime.BaseAPI {
const headerParameters: runtime.HTTPHeaders = {};

if (this.configuration && (this.configuration.username !== undefined || this.configuration.password !== undefined)) {
headerParameters["Authorization"] = "Basic " + btoa(this.configuration.username + ":" + this.configuration.password);
headerParameters["Authorization"] = "Basic " + btoa((this.configuration.username || "") + ":" + (this.configuration.password || ""));
}
const consumes: runtime.Consume[] = [
{ contentType: 'application/x-www-form-urlencoded' },
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/snakecase-discriminator/apis/FakeApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ export class FakeApi extends runtime.BaseAPI {
const headerParameters: runtime.HTTPHeaders = {};

if (this.configuration && (this.configuration.username !== undefined || this.configuration.password !== undefined)) {
headerParameters["Authorization"] = "Basic " + btoa(this.configuration.username + ":" + this.configuration.password);
headerParameters["Authorization"] = "Basic " + btoa((this.configuration.username || "") + ":" + (this.configuration.password || ""));
}
const consumes: runtime.Consume[] = [
{ contentType: 'application/x-www-form-urlencoded' },
Expand Down
Loading