Repository navigation
Conversation
#785 changed uv.lock only. Declare the floor in pyproject.toml too, so the requirement is explicit and matches the other remediation PRs (GHSA-6q48-6c7w-9gw2). Resolved version is unchanged (certifi 2026.10.19). Addresses review feedback on #785. Co-authored-by: openhands <openhands@all-hands.dev>
neubig
requested review from
all-hands-bot
and removed request for
all-hands-bot
October 23, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #785; addresses review feedback on that PR ("how come the lock file changed without pyproject changes? is it just pulling the latest released version?").
Answer
Yes — #785 only re-resolved
certifiinuv.lock, so the requirement was invisible in the manifest.Change
pyproject.toml: declare"certifi>=2026.10.19"independencieswith the GHSA reference, matching the other remediation PRs.uv.lock: minimal 2-line diff (adds thecertifidependency andrequires-distentry). Resolved version unchanged at certifi 2026.10.19. Locked with uv 0.11.32, the repo's pinned version, to avoid unrelated marker-format churn.Fixes #784 (follow-up).
This PR was created by an AI agent (OpenHands) on behalf of @neubig.