[dimerr]

Follow-up to #226. Drops divinus from the SIP-K662C6S image.

Problem

The device's defconfig (copied from firmware's hi3516cv6xx_ultimate) enables
BR2_PACKAGE_DIVINUS=y, but divinus does not support this SoC. Its HiSilicon
HAL is v1–v4 only; the divinus README's supported-hardware table reaches
Hi3516CV500/DV300 and EV200/EV300 (all V4). The Hi3516CV610 is V5 (the ot_*
MPP 2.0 generation), which divinus has no HAL for, so src/main.c exits with
Unsupported chip family! Quitting....

So the image ships a ~433 KB binary that cannot run on the chip. majestic is
the streamer that actually runs (S95majestic; there is no divinus init
script in the image, and the QEMU boot of this image starts majestic).

Change

# BR2_PACKAGE_DIVINUS is not set in this device's defconfig only.

The same line is wrong in firmware's shared hi3516cv6xx_ultimate_defconfig
and is better fixed there for every cv6xx board; that is a separate
OpenIPC/firmware PR. This device override is correct regardless, since the
device defconfig is a static copy.

Hardware tested on

Not run on a camera. Static evidence only: divinus source has no V5/cv6xx HAL,
and the shipped image starts majestic, not divinus. CI builds the image.

Evidence

# divinus src/hal/hisi: v1_* v2_* v3_* v4_* only (no v5_*)
# divinus binary (from the published cv6xx-ultimate image): HAL strings v1..v4,
#   chips named "Hi3516CV500"/"Hi3516DV300", plus "Unsupported chip family! Quitting..."
# image init: /etc/init.d/S95majestic (no S95divinus)
ci-matrix: self-test ok

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Disable unsupported divinus on SIP-K662C6S

🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 5 minutes

AI Description

• Disables divinus because its HiSilicon HAL does not support this device’s SoC.
• Leaves majestic as the configured streamer and avoids shipping an unusable binary.

High-Level Assessment

The device-specific override is appropriate for this static defconfig. Fixing the shared firmware defconfig would benefit other cv6xx boards, but is a separate upstream change.

Files changed (1) +1 / -1

Other (1) +1 / -1

hi3516cv6xx_ultimate_sip-k662c6s_defconfigDisable divinus in the SIP-K662C6S image +1/-1

Disable divinus in the SIP-K662C6S image

• Replaces the divinus package selection with an explicit disabled setting. The image continues to select majestic, while no longer including a divinus binary that cannot run on this SoC.

devices/hi3516cv6xx_ultimate_sip-k662c6s/br-ext-chip-hisilicon/configs/hi3516cv6xx_ultimate_sip-k662c6s_defconfig

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can switch off images and animations for a plain-text comment

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗