[openipc-ai]

Refs #266.

The reporter's camera shows ram: total: 128M with 512 MiB fitted, because mem=118M keeps the kernel far below the top of DRAM and the DSP has the rest. With this change it should report:

ram:
  total: 512M
  media: 392M

• Source: /proc/device-tree/iavmem/reg, or the boot log's IAVMEM line on kernels with no /proc/device-tree, as on Dahua's 3.10.73.
• Fallback: the log line is printed once. If the ring buffer has dropped it, the report falls back to what the kernel sees, so a long-running camera may still show 128M.
• Why this is now safe: ambarella: detect the SoC from the machine string #267 refused to use IAVMEM because the issue said 256 MiB. The reporter has since corrected that from the DRAM marking and an aliasing check on the running board. CLAUDE.md is updated to match.

Tested: ambarella_test with the reporter's log and a device-tree fixture, plus the host and arm32 builds.

Not tested:

• It has not run on a camera.
• The device-tree path has no real sample, only the format the kernel parses.

Sensor reporting is unchanged. Stock firmware has no /dev/i2c-*, and sensor.ko owns the bus, so driving the controller registers directly would race it.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Report Ambarella total RAM using the DSP carve-out

🐞 Bug fix 🧪 Tests 📝 Documentation 🕐 20-40 Minutes

AI Description

• Report total and media RAM from Ambarella's DSP carve-out instead of kernel-visible memory.
• Read device-tree data first, then the boot log; fall back to kernel memory when unavailable.
• Add parser tests and document the corrected RAM evidence and sensor-access limitation.

Diagram

graph TD
  DT["Device tree"] --> Choice{"DT available?"} -->|yes| Parse["Parse carve-out"] --> Valid{"Valid range?"} -->|yes| Report["RAM report"]
  Choice -->|no| Log["Boot log"] --> Parse
  Valid -->|no| Kernel["Kernel memory"] --> Report

Loading

High-Level Assessment

Using the existing HAL memory hook with device-tree data first and a boot-log fallback fits the affected kernels. Kernel-visible memory alone undercounts RAM, while relying only on the boot log would fail after its one-time line leaves the ring buffer.

Files changed (4) +109 / -5

Enhancement (1) +9 / -0

ambarella.hDeclare IAVMEM parser interfaces +9/-0

Declare IAVMEM parser interfaces

• Exposes the device-tree and boot-log parsers, with physical start and size returned in bytes.

src/hal/ambarella.h

Bug fix (1) +64 / -0

ambarella.cDerive Ambarella RAM from the IAVMEM carve-out +64/-0

Derive Ambarella RAM from the IAVMEM carve-out

• Adds device-tree and boot-log parsers and registers an Ambarella total-memory hook. The hook reports the carve-out's end as total RAM and its size as media RAM, falling back to kernel memory when no valid carve-out is found.

src/hal/ambarella.c

Tests (1) +25 / -0

ambarella_test.cTest Ambarella carve-out parsing +25/-0

Test Ambarella carve-out parsing

• Adds the reporter's boot-log example and a binary device-tree fixture. Checks missing log data and truncated or absent device-tree files.

src/hal/ambarella_test.c

Documentation (1) +11 / -5

CLAUDE.mdCorrect Ambarella RAM guidance +11/-5

Correct Ambarella RAM guidance

• Replaces the warning against trusting IAVMEM with the corrected 512 MiB board evidence and documents the two carve-out sources and kernel-memory fallback. Also explains why stock Dahua firmware does not report a sensor.

CLAUDE.md

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. Full logs can misreport camera memory ✓ Resolved

Description

ambarella_totalmem() replaces the final byte returned by get_dmesg_buf() with a terminator, even
when that byte belongs to the IAVMEM size. If a full log ends on a hexadecimal digit of that
value, the parser accepts the shortened number and reports incorrect total and media memory.

---

Tip of the day

💡 Did you know, you can switch off images and animations for a plain-text comment

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗