Skip to content

Fix teleports in TeleportUtils not respect player's yaw and pitch and ender pearl not respect player's delta movement - #539

Closed
NanaChiyo0721 wants to merge 1 commit into
PaperMC:ver/26.3.xfrom
NanaChiyo0721:ver/26.3.x-patch-2
Closed

NanaChiyo0721 wants to merge 1 commit into
PaperMC:ver/26.3.xfrom
NanaChiyo0721:ver/26.3.x-patch-2

Conversation

@NanaChiyo0721

Copy link
Copy Markdown
Contributor

No description provided.

… ender pearl not respect player's delta movement
@jpenilla

Copy link
Copy Markdown
Member

The ender pearl change doesn't change behaviour: null velocity already keeps the entity's current motion. Vanilla also sets velocity to zero on a pearl teleport rather than keeping it.

For the TeleportUtils change, the yaw and pitch come from TeleportCommand reading the destination on the command source's thread, so they can be stale. TeleportUtils already gets the destination's location on its own region, so the rotation should come from there too.

If you'd rather not go back and forth on this, I can handle it later.

@NanaChiyo0721

Copy link
Copy Markdown
Contributor Author

The ender pearl change doesn't change behaviour: null velocity already keeps the entity's current motion. Vanilla also sets velocity to zero on a pearl teleport rather than keeping it.

For the TeleportUtils change, the yaw and pitch come from TeleportCommand reading the destination on the command source's thread, so they can be stale. TeleportUtils already gets the destination's location on its own region, so the rotation should come from there too.

If you'd rather not go back and forth on this, I can handle it later.

Thanks for reminding) I would close this pr as I still have no time for this as I am still at my school)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants