Repository navigation
live dropdown search honors regex, extensive and field options - #1563
Merged
Merged
Conversation
The navbar/homepage dropdown only did a fixed substring match on
name/description/category/footprint; regex and extensive matching needed
Enter and a full results page.
When regex or extensive matching is checked in the search options, the
dropdown now sends the checked options to the typeahead endpoint, which
runs the same PartSearchFilter as the search page (selected fields,
regex, extensive, wildcard). With neither checked the request and the
existing fast autocomplete search are unchanged.
A half-typed regex (e.g. "lm(") answers an empty list instead of an
error, highlighting follows the regex or the individual words, and
toggling an option re-runs the dropdown for the text already typed.
The request-to-filter code moves from PartListsController to
PartSearchFilter::fromRequest() so both places share it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navbar/homepage dropdown only did a fixed substring match on name/description/category/footprint; regex and extensive matching needed Enter and a full results page.
When regex or extensive matching is checked in the search options, the dropdown now sends the checked options to the typeahead endpoint, which runs the same PartSearchFilter as the search page (selected fields, regex, extensive, wildcard). With neither checked the request and the existing fast autocomplete search are unchanged.
A half-typed regex (e.g.
lm() answers an empty list instead of an error, highlighting follows the regex or the individual words, and toggling an option re-runs the dropdown for the text already typed. The request-to-filter code moves from PartListsController to PartSearchFilter::fromRequest() so both places share it.