Repository navigation
Search hotkey / added - #1566
Merged
Merged
Conversation
A common shortcut on sites with search (GitHub, GitLab, YouTube, docs sites): pressing "/" anywhere on the page, outside of text fields, puts the cursor into the main search field and selects what is already there. That is the search field in the page content when there is one (e.g. the homepage), otherwise the navbar one. Modifier combinations and key presses inside inputs, textareas, selects and editable content are left alone.
The field that "/" focuses (the page's own search field, else the navbar one) shows "Type / to Search" so the shortcut is discoverable. While it is focused, and on the other search fields, the placeholder stays "Search". Placeholders are updated when a search field appears or goes away with Turbo navigation, since that changes which field "/" focuses.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1566 +/- ##
============================================
- Coverage 62.97% 62.95% -0.02%
Complexity 10071 10071
============================================
Files 748 748
Lines 32315 32315
============================================
- Hits 20351 20345 -6
- Misses 11964 11970 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Looks good and useful. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now use
/to get into the primary search, similar to GitHub, Google, Gmail, etc. Placeholder text also displays this until your cursor is in the input, at which point it reverts toSearchas it previously showed.