Skip to content

feat(people): add the Linking page and an invite landing page outside the dashboard - #149

Merged
BIA3IA merged 7 commits into
mainfrom
feat/people-linking-invite
Nov 2, 2026
Merged

feat(people): add the Linking page and an invite landing page outside the dashboard#149
BIA3IA merged 7 commits into
mainfrom
feat/people-linking-invite

Conversation

@toto04

@toto04 toto04 commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Closes #140. Stacked on #148 (#139). The backend side is PoliNetworkOrg/backend#106, and PoliNetworkOrg/backend#109 changes the invite email's link to this page. The roadmap is #146.

Linking page

Three views of People › Linking, with search:

  • Not linked: records without an account or an open invite, with the roles waiting for them. Actions: Send invite (people:write, when there's a contact email) and Link account (people:link).
  • Invites: open invites, with sent date, sender, expiry and an Expired badge. Actions: Resend, Revoke and Link account.
  • Recently linked: links from the last 30 days, with the account (directory email, or the ID), method (email invite, by hand, role given in Auth), date and who linked it.
    • Unlink (people:link) asks for a reason.
    • Its dialog explains that PoliNetwork Auth revokes the record's roles first, that the roles come back as pending for the next link, and that nothing changes if Auth refuses.
    • The action is hidden while a change for the record waits for Auth, because the backend would refuse it.

Manual link: the dialog searches the IdP directory. Once you pick an account, it confirms which one and how many roles go to Auth, acting as you. It warns when that account is already linked to another record.

Invite landing page: /people/invite?token=…

  • It sits outside the gated dashboard shell. Its server functions use a new peopleInviteMiddleware: signed in, no dashboard permission needed, and the token is the proof. An account with no permissions at all can open it.

  • The flow:

    1. sign in (the page redirects to the IdP and back);
    2. "Link this account to ?";
    3. confirm;
    4. the result.

  • The result:

    • each role as Applied, Waiting for Auth or Refused by Auth with Auth's reason;
    • or "Your account is linked, PoliNetwork Auth is applying your roles", with Check again, while the account can't read My area yet (that needs people:self).

    After accepting, the URL switches to ?linked=true, so a reload shows the result instead of a spent link.

  • The copy says:

    • you can sign in with any account, not only the one at the invited address;
    • the link works once and expires on a given date;
    • to ask whoever invited you (HR, or your Team Lead) for a new one.

    Use another account signs out. An invalid or expired link shows the backend's message.

  • Old links: /dashboard/account/me?peopleInvite=<token> redirects to the new page before the dashboard's gate, so invites already sent keep working. My area no longer accepts invites itself.

Testing

  • pnpm check (0 errors; the 28 warnings are in untouched test files), pnpm typecheck, pnpm test (186 passed), pnpm build.
  • A new test has an account with no permissions preview and accept an invite through the fake. It checks that the roles are sent to Auth, the link is listed in Recently linked, and the token doesn't work a second time.
  • Agent mode, headless Chromium:
    • Linking at 1440 px;
    • the landing page at 1280 px and 390 px: a valid link, a spent link, and the result after linking;
    • the old URL answers 307 to /people/invite?token=….
  • Not done yet, from the issue's Done when: both paths end to end against a real backend and Auth in staging, including an account with no permissions accepting an invite. That needs staging with feat(people)!: link records by email invite or by hand, and unlink through Auth backend#106 and feat(esign): choose which roles and permissions may use each drive #109 deployed. The IdP must also give a token with the backend's admin scope to accounts that have no dashboard permissions; the backend's me.invite and me.acceptInvite require it.

Deploy

With #148. PoliNetworkOrg/backend#109 can go out before or after this: the redirect keeps both link formats working.

toto04 added 2 commits October 31, 2026 02:36
@toto04
feat(people)!: rebuild the People pages on records and assignments sy…
ed8e423 
…nced to Auth

Phase 1 pages (#139) on the backend's new People API (PoliNetworkOrg/backend#105, #106). The contract is now a copy of
the backend's: a record has a name and contacts, and its roles are assignments (Admin, Capo Admin, team member or
Lead) whose status says where each stands with PoliNetwork Auth: pending until linked, waiting for Auth, applied, or
refused with Auth's reason.

- Overview: filters by role, team, account and status with Auth.
- Person page: each role with its status and Auth's refusal, past roles, account, HR notes and history, with actors
  named from linked records.
- Add person: only the name is required; contacts and starting roles are optional, and a refused role is reported
  without undoing the record.
- Admins: admins with their Capo Admin of reference (set or change), and Capo Admins with their scope (appoint,
  change, end).
- Capo Admin area: read-only, laid out so management can be added.
- Teams: members and Leads, honouring which roles Auth binds; a Lead manages their team's members.
- My area: own record, roles and their status.
- New permission people:link for linking by hand and unlinking; unlinking takes a reason and Auth revokes the
  roles first.
- The Design team is Design & Marketing.
- Agent mode: fixtures cover linked, invited and unlinked records and every assignment status.

BREAKING CHANGE: requires the backend's Phase 1 People API (PoliNetworkOrg/backend#105 and #106) and the people:link
permission in the IdP.
@toto04
feat(people): add the Linking page and an invite landing page outside…
eb8cbbf 
… the dashboard

#140, on PoliNetworkOrg/backend#106 and #109.

- Linking: records without an account (send an invite, link by hand), open invites with their expiry (resend,
  revoke), and links of the last 30 days with account, method, date and who did it. Unlink asks for a reason and
  explains that Auth revokes the roles first, and that they come back as pending.
- The link dialog confirms which account is linked and how many roles go to Auth.
- /people/invite stands outside the gated dashboard shell, so any signed-in account can open it, including one with
  no permissions: it asks "Link this account to <name>?", links on confirmation, then shows the roles as Auth applies
  or refuses them. Its copy says any account works, the link works once, and who to ask when it has expired.
- Links to /dashboard/account/me?peopleInvite= redirect there before the dashboard's gate; My area no longer accepts
  invites.
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5668a991-5517-48b6-8e41-2f84fec4bb08
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This was referenced Oct 31, 2026
Closed
Closed
toto04 added 4 commits October 31, 2026 03:04
@toto04
fix(people): keep a backend outage from looking like a dead invite link
bbceadc 
The invite landing page showed "This link doesn't work" and told the person to ask for a new invite for any error
from `me.invite`, including a backend outage or a contract mismatch, with the raw error as the reason. Only the
backend's NOT_FOUND (spent, revoked or expired token) now means a dead link; anything else reaches the route's
error state, which offers Retry.

Also:
- say that using another account means opening the email link again, since signing out returns to the dashboard,
  not the invite;
- count Linking search results as records, invites or links, not "results" (docs/design.md §7);
- replace design.md's stale Linking entry (Needs review queue) with the three segments and the landing page;
- reflow the AGENTS.md People paragraph.
@toto04
fix(people): match the backend's role rules in the People pages and a…
7b16f3e 
…gent mode

Review fixes for the Phase 1 People pages (#139):

- Add to team: a "Team Lead" choice no longer carries over to a team that can't take
  a Lead, which the backend refused.
- Capo Admin pickers leave out Capo Admins whose appointment Auth hasn't confirmed:
  the backend only accepts one in effect.
- After a failed role change the page reloads behind the dialog, since the backend
  records Auth's refusal (a refused start ends the assignment) before answering.
- Start dates default to today in Europe/Rome, the calendar the backend checks them
  against, including the roles Add person starts with on the server.
- Add person no longer lists a team that offers no role, and the refusal alert no
  longer doubles a refusal's final period.
- A record waiting for Auth keeps the actions that stay in People (Capo Admin of
  reference, scope, team fields), as the backend allows them.
- Former team members sort by their end date; empty action slots no longer leave a
  blank strip on mobile cards.
- Agent mode counts assignments in effect as the backend does (pending ones
  included, starts waiting for Auth not), lets anyone give up their own role, ends
  roles that aren't bound, and clears Capo Admin references once Auth confirms the
  end for a linked record. Docs and tests follow.
@toto04
Merge remote-tracking branch 'origin/feat/people-phase1-pages' into f…
134bbf1 
…eat/people-linking-invite
@toto04
fix(people): reload the page when linking or unlinking fails
cd28510 
The backend records Auth's refusal, or a link it couldn't finish, before it answers with the error, so the page
behind the dialog reloads to show it, as role changes already do since #148.
Base automatically changed from feat/people-phase1-pages to main November 2, 2026 18:10
@BIA3IA
BIA3IA merged commit a6c0545 into main Nov 2, 2026
2 checks passed
@BIA3IA
BIA3IA deleted the feat/people-linking-invite branch November 2, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BIA3IA BIA3IA BIA3IA approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[People · Phase 1] Linking page and invite landing page

2 participants

@toto04 @BIA3IA