Skip to content

[feat] settings forwards backwards keybinds - #1151

Open
simply-sunny wants to merge 3 commits into
Polyfrost:mainfrom
simply-sunny:feat/settings-forwards-backwards-keybinds
Open

simply-sunny wants to merge 3 commits into
Polyfrost:mainfrom
simply-sunny:feat/settings-forwards-backwards-keybinds

Conversation

@simply-sunny

Copy link
Copy Markdown

Description

added keybinds for settings, and for going back and forward

Shortcut Action
Cmd/Ctrl+, Open Settings (does nothing if you're already in Settings)
Cmd/Ctrl+[ Back
Cmd/Ctrl+] Forward

im on mac so these are what i expect, and not having them feels broken. for windows and linux i just used the same keys with ctrl, but i cant test there. please let me know if that should change and what the standard is (maybe alt+left/right for back and forward?)

Related Issue(s)

n/a

How to test

  1. run and press cmd+, => settings opens, and pressing it again while in settings does nothing
  2. open some pages and press cmd+[ => goes back one page at a time, cmd+] goes forward again
  3. none of the three work while a popup is open, or on the onboarding screens (like review terms)

test: cargo test -p oneclient_app animated_outlet

Documentation

i dont think so? these are just app shortcuts with no api changes, but please let me know if this is needed.

Cmd+, opens settings, Cmd+[ goes back and Cmd+] goes forward, matching browser history navigation. Ignored while an overlay is open.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant