Repository navigation
[feat] settings forwards backwards keybinds - #1151
Open
simply-sunny wants to merge 3 commits into
Open
simply-sunny wants to merge 3 commits into
simply-sunny wants to merge 3 commits into
Conversation
Cmd+, opens settings, Cmd+[ goes back and Cmd+] goes forward, matching browser history navigation. Ignored while an overlay is open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
added keybinds for settings, and for going back and forward
Cmd/Ctrl+,Cmd/Ctrl+[Cmd/Ctrl+]im on mac so these are what i expect, and not having them feels broken. for windows and linux i just used the same keys with ctrl, but i cant test there. please let me know if that should change and what the standard is (maybe alt+left/right for back and forward?)
Related Issue(s)
n/a
How to test
test:
cargo test -p oneclient_app animated_outletDocumentation
i dont think so? these are just app shortcuts with no api changes, but please let me know if this is needed.