Repository navigation
Bump vulnerable website dependencies and move the SvelteKit example to kit 3 - #125
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
This PR migrates the SvelteKit example app to Kit 3.1.0 by updating dependencies (adapter-auto 8, vite-plugin-svelte 7, TypeScript 6, Vite 8), moving adapter and preprocess config from svelte.config.js into vite.config.ts, and updating tsconfig.json to extend $app/tsconfig with explicit includes. It also updates the website lockfile to patch/minor releases that clear Dependabot alerts. Testing confirms Kit 3 config checks pass, server bundle builds, vitest passes, and svelte-check shows no new errors.
review-bot, model nvidia/nemotron-3-ultra-550b-a55b:free, verdict approve
Replaces #123. Its
@sveltejs/kit3.1.0 bump does not install or build without more changes to the example app.Website (
apps/website/pnpm-lock.yaml)Lockfile from #123, unchanged: fast-uri 3.1.9, serialize-javascript 7.1.4, body-parser 1.20.9, launch-editor 2.14.2, qs 6.16.2, undici 7.30.1. All are patch or minor releases, and each clears an open Dependabot alert.
SvelteKit example (
apps/sveltekit-app)The kit alerts (open redirect in enhanced form submission, XSS through a prerendered cache-control header) are fixed only in 3.0.0. Kit 3 needs:
vite ^8,@sveltejs/vite-plugin-svelte ^7,typescript ^6, and adapter-auto 8. The app pinned Vite 6, plugin 6, TS 5 and adapter-auto 3, so this PR bumps them too.sveltekit()Vite plugin. Kit 3 refuses to start whensvelte.config.jsexists, so the adapter and preprocess options moved intovite.config.ts.tsconfig.jsonextending$app/tsconfigwith an explicitinclude, which kit 3 checks at build time.The app uses none of the APIs kit 3 removed or changed.
Testing
In a clean install of the app (Node 24):
vite buildgets through kit 3's config checks and builds the server bundle. The client build then fails on the published@project516/ffmpeg-wasm0.17.0, which Vite cannot bundle. This is not new: the app on master with Vite 6 fails with the same error. Pass a literal worker type so Vite can bundle the ESM build #124 fixes it, and with that change the app builds and emits the worker chunk.vitest runpasses.svelte-checkreports the same 6 errors as on master, and no new ones.CI does not build the example apps.
Noticed, not fixed
svelte-checkerrors in the example on master and here:vite.config.tshas untyped middleware parameters and no@types/node, andFFmpegDemo.sveltepasses anArrayBufferLiketoBlob.