Repository navigation
test: type the grouped sum result so mypy passes again - #1194
Closed
MaykThewessen wants to merge 1 commit into
Closed
MaykThewessen wants to merge 1 commit into
MaykThewessen wants to merge 1 commit into
Conversation
grouped_sum returns a union, so the test dict needs a narrowed value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merging this PR will not alter performance1 note
Comparing Footnotes
|
Collaborator
|
already solved on master - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check typesfails on master since #1192 (3 mypy errors intest/test_spec_operators.py):grouped_sumreturns a union, so the untypedsummeddict cannot go intoassert_linequal. This narrows the result with anisinstanceassert and types the dict. Test only, no behaviour change.Note
The following content was generated by AI.
Checks
mypy .on this branch:Success: no issues found in 153 source files(master: 3 errors, same as CI run 44543554770).test/test_spec_operators.pywith mathspec installed: 143 passed.Checklist
AGENTS.md).doc.doc/release_notes.rstof the upcoming release is included. Not needed: no user-facing change.🤖 Generated with Claude Code