Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centered SQ8 inner-product blobs currently store
x_mean_ipfrom the original input, while the stored/stored kernel operates on the reconstructed quantized vector. This mixes two representations in the mean correction. Compute the correction frommin + delta * code + meaninstead, using the same fused quantization path as SQ4.This is a separate behavior change for MOD-21005, stacked on #1099. #1101 keeps its promise of preserving SQ8 behavior. Retarget after the lower PRs merge.
Changes:
find_min_max.Compatibility: no field-layout or encoding-version change. Existing V5 snapshots retain their stored corrections when loaded; newly inserted or replaced vectors use the corrected formula. Loading does not migrate or rewrite existing vectors.
Validation on dorer-intel (GCC 13, Release), final commit
e9311eb6:test_components: 60 passed.test_hnsw_sq8: 209 passed.test_hnsw_sq4: 82 passed; 12 intentional single-value instances of multi-only cases skipped.Matched DBpedia screen: 8,192 candidates (rows 0–8191), 128 queries (rows 8192–8319), D768, normalized FP32 input, mean computed from candidates, double-precision exhaustive ground truth. HNSW: M16, efConstruction200, efRuntime200, sequential insertion.
9f3f5b92)e9311eb6)The HNSW @100 difference is one additional hit across 12,800 expected hits; this small sample establishes no material recall change, rather than a general recall improvement. Fixture:
dbpedia-cosine-dim768-test_vectors.raw, SHA2564c63a75134c43b4eefe599800c6d7a041b503cdeb1344567b7be4c28a520f2a6.