Repository navigation
[MOD-18996] Transfer allocation accounting between allocators - #1120
Merged
Merged
Conversation
1 of 2 tasks
Add Ubuntu 26.04 install script for the new ubuntu-latest runner GitHub's ubuntu-latest image moved to Ubuntu 26.04, and install_script.sh failed with "ubuntu_26.04.sh: No such file or directory". apt.llvm.org has no LLVM 18 repo for 26.04 (resolute), so install clang-format-18 from the Ubuntu archive and point the unversioned clang-format used by check-format.sh at it. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.8-rse #1120 +/- ##
===========================================
+ Coverage 97.55% 97.58% +0.02%
===========================================
Files 142 142
Lines 9095 9102 +7
===========================================
+ Hits 8873 8882 +9
+ Misses 222 220 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport allocator transfer from #1115 onto the VecSim revision pinned by Search 8.8-rse. Also cherry-pick upstream Ubuntu 26.04 install support (#1111), required because ubuntu-latest moved to 26.04.
The three allocator tests pass locally under ASan/UBSan with leak checking. CI is rerunning after the setup fix.
Note
Medium Risk
Changes VecSim memory accounting semantics; misuse (wrong deleter or concurrent transfers) could skew usage stats or double-free, though behavior is covered by new unit tests.
Overview
Adds
VecSimAllocator::transferAllocationToso an existing allocation's byte accounting can move from one allocator instance to another without reallocating or freeing the block—supporting scenarios like tiered indexes swapping ownership across layers.The API no-ops on null or self-transfers, documents that callers must fix any owning deleter before freeing via the destination, and notes that the two counters are updated non-atomically. Unit tests cover balanced accounting, alignment/payload preservation, edge cases, and verify no extra malloc/free traffic on transfer.
Also adds
.install/ubuntu_26.04.sh, installingclang-format-18from the Ubuntu archive and symlinkingclang-formatfor format checks where LLVM's apt repo lacks 26.04 packages, plus the usual build dependencies.Reviewed by Cursor Bugbot for commit 15ce4fb. Bugbot is set up for automated code reviews on this repo. Configure here.