Skip to content

fix(helper): Accept date formats without a year or month #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zigzagdev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(helper): Accept date formats without a year or month #1883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adb66ee
fix: Accept date formats without a year or month
zigzagdev Oct 25, 2026
beeffdb
test: Cover date formats without a year or month
zigzagdev Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Helpers/CanValidateDateTime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ private function isDateFormat(string $format): bool
private function isDateInformation(array $info): bool
{
if ($info['day']) {
return checkdate((int) $info['month'], $info['day'], (int) $info['year']);
return checkdate(
$info['month'] === false ? 1 : $info['month'],
$info['day'],
$info['year'] === false ? 1 : $info['year'],
);
}

return checkdate($info['month'] ?: 1, 1, $info['year'] ?: 1);
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/Validators/DateTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ public static function providerForValidInput(): iterable
[new Date('F jS, Y'), 'May 1st, 2017'],
[new Date('Ydm'), 20173112],
[new Date(), '2020-02-29'],
[new Date('d/m'), '15/03'],
[new Date('m/d'), '03/15'],
[new Date('d'), '15'],
[new Date('F j'), 'March 5'],
];
}

Expand All @@ -76,6 +80,7 @@ public static function providerForInvalidInput(): iterable
[new Date('d'), 1],
[new Date('Y-m'), '2014-99'],
[new Date('m'), '99'],
[new Date('d/m'), '31/02'],
];
}
}
Loading