Repository navigation
refactor: keep masks in simd until we need to covert them to bitmasks - #388
Merged
Merged
Conversation
Dr-Emann
force-pushed
the
stable_simd_compress
branch
from
October 12, 2026 04:14
cc8d32f to
7064443
Compare
Dr-Emann
force-pushed
the
stable_simd_compress
branch
from
October 22, 2026 03:23
7064443 to
647c258
Compare
Kerollmops
previously requested changes
Oct 22, 2026
Kerollmops
left a comment
Member
There was a problem hiding this comment.
Thanks for bumping the fearless_simd, I didn't saw that before.
It seems that the CI is unhappy about this change 👀
The array store vector ops now pass lane masks around as `mask16x8<S>` instead of turning them into `u8` bitmasks at every step. This also uses simd_ne where applicable, and .compress(), new in fearless_simd 1.1
Dr-Emann
force-pushed
the
stable_simd_compress
branch
from
October 23, 2026 00:14
647c258 to
d6b331e
Compare
Merged
Dr-Emann
force-pushed
the
stable_simd_compress
branch
from
October 23, 2026 14:10
3204e91 to
d6b331e
Compare
Member
Author
|
Comparing this branch vs
Geometric Means
Results varied 2% between passes for the median benchmark and 6.4% at the 90th percentile, so differences of a few percent are probably noise.
|
Member
|
Hey @Dr-Emann 👋 Thank you very much for the performance measurements. Performances are impressive and it's faster than the SIMD implementation we had. I'm ready to merge all of your PR's in one go. Thank you very much and be ready 🌵 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The array store vector ops now pass lane masks around as
mask16x8<S>instead of turning them intou8bitmasks at every step.