Repository navigation
support: use a keyword argument for datetime.fromtimestamp - #1146
Merged
Merged
Conversation
This is how it's documented, cf. * https://docs.python.org/3/library/datetime.html#datetime.datetime.fromtimestamp * https://docs.python.org/3/library/datetime.html#datetime.datetime.utcfromtimestamp Quoting from the doc: > the recommended way to create an object representing a specific > timestamp in UTC is by calling datetime.fromtimestamp(timestamp, > tz=timezone.utc). This is just a nit, it doesn't _fix_ anything, it's just better style IMO.
steadytao
changed the title
steadytao
approved these changes
Nov 4, 2026
steadytao
left a comment
steadytao
left a comment
Member
There was a problem hiding this comment.
Nonetheless its good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is how it's documented, cf.
Quoting from the doc:
This is just a nit, it doesn't fix anything, it's just better style IMO.