Skip to content

syscall: skip unsupported symlink chmod - #1148

Open
steadytao wants to merge 1 commit into
masterfrom
symlink-chmod-unsupported
Open

steadytao wants to merge 1 commit into
masterfrom
symlink-chmod-unsupported

Conversation

@steadytao

Copy link
Copy Markdown
Member

Fixes #1147

Summary

Restores the skipped-operation result when no-follow symlink chmod is unsupported. Batch-replay regression for non-0777 symlink modes, covering new and existing normal and dangling links and checking that target permissions and contents remain unchanged.

@steadytao

Copy link
Copy Markdown
Member Author

@ckujau please test

@steadytao steadytao added the bug Something isn't working label Nov 4, 2026
@mtsapv

mtsapv commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Thanks so much for doing this. I owe you. While the patch itself was fairly straightforward, I will admit that the needed test was definitely slowing me down. I'm making a close study of yours in anticipation of possible future need.

I've run this patch though a variety of stress tests (using 6 different architectures), including the example given by @ckujau as well as a complete transfer of an OpenBSD system to Debian13. The latter was done with both version 3.5.2 (which produced many "unsupported" errors) and with this patch (which ran completely clean). Hopefully @ckujau will have the same results. I've added to latter test to my regular checklist.

Sorry to have created the need for this patch. Thanks again. Take care.

@ckujau

ckujau commented Nov 5, 2026

Copy link
Copy Markdown

Sorry for the delay, I did not expect fix to be available this quickly :-)

Yes, with that commit applied, the error is indeed gone. I can copy symlinks off *BSD systems again, w/o that error message. Thank you for fixing this so quickly!

Don't know if you do these around here, but feel free to add:

Tested-by: Christian Kujau lists@nerdbynature.de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operation not supported when copying symlinks from a BSD system

3 participants