Skip to content

fix(scroll): animate short-list bottom autoscroll - #2546

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/fix-short-list-bottom-autoscroll
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/fix-short-list-bottom-autoscroll

Conversation

@efegokdemir

Copy link
Copy Markdown

Description

Fixes (issue #2543)

When startRenderingFromBottom fills the gap above a short list with a margin, appending a row shrinks that margin immediately and leaves no scroll distance for scrollToEnd to animate. This animates the shrinking offset with a native-driver translation while retaining native scrolling for content taller than the viewport. Regression tests cover short and long lists, appends during an active adjustment and animateAutoScrollToBottom: false.

The short-list regression fails on main because Animated.timing is never called. yarn test --runInBand passes (16 suites, 203 tests), as do yarn type-check, yarn build, ESLint on the changed files and Prettier.

Reviewers’ hat-rack 🎩

  • Check the margin translation with native autoscroll for short-to-long content.

Screenshots or videos (if needed)

Not captured: Xcode/iOS Simulator is unavailable in this environment.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant