Repository navigation
fix(solver): keep a runner's declaration only for partitioned search - #223
Merged
Merged
Conversation
A compiled runner kept the declaration its graph was compiled from, inline, for the whole solve, although only a partitioned_search phase compiles partition runners from it. Every solve held a second copy of the search context, and every runner grew by the declaration's size. The runner now keeps the declaration, boxed, only when the configuration has a partitioned phase. Against v0.24.0, construction first fit goes from +3.9% to +0.8% instructions and from +27.8% to +4.0% max RSS. Closes #220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220.
A compiled runner kept its full declaration (descriptor and search context) inline for the whole solve; only partitioned_search uses it. The runner now keeps it, boxed, only when the configuration has a partitioned phase.