Repository navigation
fix(bench): run both zero-regression gate sides from equal-length paths - #230
Merged
Merged
Conversation
The gate ran the baseline from binaries/baseline-<case> and the candidate from binaries/candidate-<case>, one character longer. The kernel copies the executable path onto the new process's stack, so the path length shifts every stack address and with it cache behaviour. One list_swap binary measured about 260k cache-references from 88-character paths and about 295k from 89-character ones; on the 0.25.0 gate the baseline path was 88 characters and the candidate's 89, which failed list_swap cache-references by +12% while the identical binary measured the same as v0.24.0 from an equal-length path. Both sides now run from binaries/base/<case> and binaries/cand/<case>. Thresholds, metrics, trial counts and the pass rule are unchanged. Closes #229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #229. Both gate sides run from
binaries/base/<case>andbinaries/cand/<case>; thresholds, metrics, trials and the pass rule are unchanged. Evidence is in #229. Smoke run on this branch: binaries land under base/ and cand/,list_swapcache-references -0.6% against v0.24.0.