Repository navigation
Conversation
The Codeception based acceptance tests were migrated to Playwright and removed from the Core in May 2026 (for example "[TASK] Drop codeception classic acceptance pipeline"). Build/Scripts/runTests.sh has no "-s acceptance" any more; browser tests run with "-s e2e" and its variants e2e-prepare, e2e-browser and e2e-install, and "-M classic" selects a classic instead of a Composer installation. The guide still told contributors to run "-s acceptance", which fails. Update the commands, the help output excerpt, the report paths and the wording in the review and workflow pages. The old review check anchor is kept next to a new one. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Olivier Dobberkau <olivier.dobberkau@dkd.de>
froemken
approved these changes
Oct 3, 2026
froemken
left a comment
froemken
left a comment
Contributor
There was a problem hiding this comment.
Hi @dkd-dobberkau,
Thank you for this thorough update.
Migrating the documentation from the obsolete Codeception acceptance suite to the current Playwright end-to-end setup (-s e2e) aligns the guide with the current TYPO3 Core tooling. Thank you in particular for keeping the existing _common-review-checks-acceptance anchor intact alongside the new one to preserve incoming links.
The commands, report paths, and section markup are all accurate.
Best regards,
Stefan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Codeception based acceptance tests were migrated to Playwright and
removed from the Core in May 2026 (for example "[TASK] Drop codeception
classic acceptance pipeline"). Build/Scripts/runTests.sh has no
"-s acceptance" any more; browser tests run with "-s e2e" and its
variants e2e-prepare, e2e-browser and e2e-install, and "-M classic"
selects a classic instead of a Composer installation. The guide still
told contributors to run "-s acceptance", which fails.
Update the commands, the help output excerpt, the report paths and the
wording in the review and workflow pages. The old review check anchor
is kept next to a new one.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com
Signed-off-by: Olivier Dobberkau olivier.dobberkau@dkd.de