Skip to content

Update tt.py and remove GraphicsDemo - #66

Merged
KenVanHoeylandt merged 3 commits into
mainfrom
develop
Nov 1, 2026
Merged

KenVanHoeylandt merged 3 commits into
mainfrom
develop

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added host and sdk commands to manage the connected device and SDK version.
    • The tool can display device information and remember device and SDK settings between runs.
    • When no project manifest specifies an SDK, selection uses a saved local version or the connected device’s reported version before prompting.
    • Help output now lists the built-in commands.
  • Changes
    • Removed the interactive project-generation workflow.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a63c24f5-37b4-4e0c-8bc6-70dfbcbc247b
Commits

Reviewing files that changed from the base of the PR and between 182b44b and e69bf0f.

Files selected for processing: 35
  • Apps/AirMouse/manifest.properties
  • Apps/Brainfuck/manifest.properties
  • Apps/Breakout/manifest.properties
  • Apps/BusyBoxVi/manifest.properties
  • Apps/Calculator/manifest.properties
  • Apps/Diceware/manifest.properties
  • Apps/Doom/manifest.properties
  • Apps/EpubReader/manifest.properties
  • Apps/EspNowBridge/manifest.properties
  • Apps/GPIO/manifest.properties
  • Apps/GfxBenchmark/manifest.properties
  • Apps/GraphicsDemo/main/CMakeLists.txt
  • Apps/GraphicsDemo/main/Include/Application.h
  • Apps/GraphicsDemo/main/Source/Application.cpp
  • Apps/GraphicsDemo/main/Source/Main.cpp
  • Apps/GraphicsDemo/manifest.properties
  • Apps/HelloWorld/manifest.properties
  • Apps/M5UnitTest/manifest.properties
  • Apps/Magic8Ball/manifest.properties
  • Apps/MediaKeys/manifest.properties
  • Apps/MidiController/manifest.properties
  • Apps/MystifyDemo/manifest.properties
  • Apps/MystifySpiDemo/manifest.properties
  • Apps/Neatvi/manifest.properties
  • Apps/Rcc700/manifest.properties
  • Apps/SatelliteTracker/manifest.properties
  • Apps/SerialConsole/manifest.properties
  • Apps/Snake/manifest.properties
  • Apps/TamaTac/manifest.properties
  • Apps/TodoList/manifest.properties
  • Apps/Tone/manifest.properties
  • Apps/TwoEleven/manifest.properties
  • Apps/UnitLcdGfxDemo/manifest.properties
  • Apps/WebServer/manifest.properties
  • Apps/Xcc700/manifest.properties

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 51d35eee-484b-4181-8c31-bf132942c951
Commits

Reviewing files that changed from the base of the PR and between 5cf76a5 and 182b44b.

Files selected for processing: 2
  • Apps/GraphicsDemo/CMakeLists.txt
  • tt.py
Files with no reviewable changes: 1
  • Apps/GraphicsDemo/CMakeLists.txt

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The GraphicsDemo CMake configuration is removed. tt.py adds built-in host and sdk commands, TLS device-info lookup, and persistent device-host and SDK-version settings. SDK selection uses a project manifest when present. Otherwise, it checks a stored SDK version, then the stored device, then an interactive prompt. The tool version changes to 1.4.0. The previous interactive project-generation flow is removed.

Merge Risk: Minimal · previous review 182b4

No actionable issue currently blocks merging. Normal checks should still exercise the device connection.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 78.57% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies both main changes: updating tt.py and removing GraphicsDemo.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 78.57% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 14 functions across 1 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@KenVanHoeylandt
KenVanHoeylandt merged commit 75eaa29 into main Nov 1, 2026
36 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the develop branch November 1, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant