Skip to content

chore(preact-query/utils): disable 'react/exhaustive-deps' for the stable '_instance' to keep the upstream 'useSyncExternalStore' - #12289

Merged
sukvvon merged 1 commit into
mainfrom
chore/preact-query-utils-disable-exhaustive-deps
Oct 23, 2026
Merged

sukvvon merged 1 commit into
mainfrom
chore/preact-query-utils-disable-exhaustive-deps

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 23, 2026

Copy link
Copy Markdown
Member

🎯 Changes

Add oxlint-disable-next-line react/exhaustive-deps comments to the two effects in useSyncExternalStore in packages/preact-query/src/utils.ts.

The effects omit _instance from their dependencies. _instance comes from the initial useState value and forceUpdate({ _instance }) always passes the same object back, so it never changes. The dependency arrays are kept as they are in the linked upstream implementation instead of being changed to satisfy the rule.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

…able '_instance' to keep the upstream 'useSyncExternalStore'
@sukvvon sukvvon self-assigned this Oct 23, 2026
@changeset-bot

changeset-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f6d9548

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit f6d9548

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 3s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-23 01:05:30 UTC

@sukvvon
sukvvon merged commit 2de1d1e into main Oct 23, 2026
7 of 8 checks passed
@sukvvon
sukvvon deleted the chore/preact-query-utils-disable-exhaustive-deps branch October 23, 2026 01:02
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 67a8784 and f6d9548.

📒 Files selected for processing: 1
  • packages/preact-query/src/utils.ts
+-----------------------------+
| ░R░e░v░i░e░w░ ░i░n░ ░b░i░o░ |
+-----------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.76 KB (0%)
react minimal 8.59 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant