Repository navigation
chore(preact-query/utils): disable 'react/exhaustive-deps' for the stable '_instance' to keep the upstream 'useSyncExternalStore' - #12289
Conversation
…able '_instance' to keep the upstream 'useSyncExternalStore'
|
|
View your CI Pipeline Execution ↗ for commit f6d9548
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
size-limit report 📦
|
🎯 Changes
Add
oxlint-disable-next-line react/exhaustive-depscomments to the two effects inuseSyncExternalStoreinpackages/preact-query/src/utils.ts.The effects omit
_instancefrom their dependencies._instancecomes from the initialuseStatevalue andforceUpdate({ _instance })always passes the same object back, so it never changes. The dependency arrays are kept as they are in the linked upstream implementation instead of being changed to satisfy the rule.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact