test(*/useQuery): rename the 'throwOnError' callback parameter to 'err' to avoid shadowing the returned 'error' by sukvvon · Pull Request #12295 · TanStack/query

sukvvon · 2026-10-23T07:22:44Z

🎯 Changes

In the should handle throwOnError function based on actual error state test of react-query and preact-query, the throwOnError callback's error parameter shadowed the error destructured from the useQuery result (no-shadow).

Rename the callback parameter to err, matching the other throwOnError: (err) => ... callbacks in the same files.
Apply the same change to preact-query, which has the same test code as react-query.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Updated error-handling test terminology across the Preact and React query packages. The tests continue to check for the same error message, and this change does not alter application behavior or affect what users see. No changes were made to the public API or product functionality.

…r' to avoid shadowing the returned 'error'

changeset-bot · 2026-10-23T07:22:52Z

⚠️ No Changeset found

Latest commit: 8318373

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-23T07:23:13Z

View your CI Pipeline Execution ↗ for commit 8318373

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	5m 9s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	10s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-23 07:29:05 UTC

github-actions · 2026-10-23T07:23:45Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-10-23T07:24:07Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Source mode: Auto
Repository: TanStack/query
Branch: test/use-query-rename-throw-on-error-param
File: .coderabbit.yaml
Commit: 8318373
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: ad516c99-4f8a-4ac8-95be-fe070dd0bdf9

📥 Commits

Reviewing files that changed from the base of the PR and between 86b9f20 and 8318373.

📒 Files selected for processing: 2

packages/preact-query/src/__tests__/useQuery.test.tsx
packages/react-query/src/__tests__/useQuery.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The Preact and React query tests rename the throwOnError callback parameter from error to err. The message checks for '404' remain unchanged.

Changes: Test callback names

Layer / File(s)	Summary
Rename callback parameter `packages/preact-query/src/__tests__/useQuery.test.tsx`, `packages/react-query/src/__tests__/useQuery.test.tsx`	Both tests use `err` as the `throwOnError` callback parameter. The predicate remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: tkdodo, s-jooyoung

Merge Risk: ⚪ Minimal · up to 83183

No actionable merge-blocking risk is present.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly describes the main change: renaming the `throwOnError` callback parameter to `err` to avoid shadowing the returned `error`.
Description check		The description explains the change and motivation, identifies both affected packages, and completes the required checklist and release-impact sections.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-23T07:24:59Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12295

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12295

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12295

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12295

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12295

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12295

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12295

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12295

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12295

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12295

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12295

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12295

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12295

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12295

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12295

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12295

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12295

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12295

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12295

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12295

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12295

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12295

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12295

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12295

commit: 8318373

github-actions · 2026-10-23T07:25:17Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

test(*/useQuery): rename the 'throwOnError' callback parameter to 'er…

8318373

…r' to avoid shadowing the returned 'error'

sukvvon self-assigned this Oct 23, 2026

sukvvon merged commit 6bdeb13 into main Oct 23, 2026
9 checks passed

sukvvon deleted the test/use-query-rename-throw-on-error-param branch October 23, 2026 08:09

Navigation Menu

Repository navigation

test(*/useQuery): rename the 'throwOnError' callback parameter to 'err' to avoid shadowing the returned 'error' - #12295

test(*/useQuery): rename the 'throwOnError' callback parameter to 'err' to avoid shadowing the returned 'error'#12295
sukvvon merged 1 commit into
mainfrom
test/use-query-rename-throw-on-error-param

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 23, 2026

Uh oh!

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 23, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 23, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading