Skip to content

docs(vue-query/queryClient): remove the author tag from the 'invalidateQueries' comment - #12296

Merged
sukvvon merged 1 commit into
mainfrom
docs/vue-query-query-client-remove-author-tag
Oct 23, 2026
Merged

sukvvon merged 1 commit into
mainfrom
docs/vue-query-query-client-remove-author-tag

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

Remove the (dosipiuk): author tag from the comment in invalidateQueries, which was flagged by cspell. The authorship is kept in the git history.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Documentation
    • Clarified that query refetching is delayed until the next macro task, allowing reactive values to update.

@sukvvon sukvvon self-assigned this Oct 23, 2026
@changeset-bot

changeset-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7eb74c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 7eb74c4

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 36s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-23 08:35:35 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 6bdeb13 and 7eb74c4.

📒 Files selected for processing: 1
  • packages/vue-query/src/queryClient.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The change removes an attribution from a comment in QueryClient.invalidateQueries. It does not change runtime behavior.

Changes: Query invalidation comment

Layer / File(s) Summary
Update invalidation comment
packages/vue-query/src/queryClient.ts
The comment no longer includes an attribution. Its description of the delayed refetchQueries call remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: dogpawhat

Merge Risk: ⚪ Minimal · up to 7eb74

No actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the removal of the author tag from the invalidateQueries comment.
Description check Passed The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, records the completed checklist items, and correctly identifies the change as docs-on…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, records the completed checklist items, and correctly identifies the change as docs-only with no release impact.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12296

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12296

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12296

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12296

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12296

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12296

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12296

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12296

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12296

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12296

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12296

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12296

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12296

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12296

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12296

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12296

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12296

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12296

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12296

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12296

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12296

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12296

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12296

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12296

commit: 7eb74c4

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.76 KB (0%)
react minimal 8.59 KB (0%)

@sukvvon
sukvvon merged commit 75b5b6c into main Oct 23, 2026
9 checks passed
@sukvvon
sukvvon deleted the docs/vue-query-query-client-remove-author-tag branch October 23, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant