Skip to content

fix: align page size options with validation limit - #1413

Merged
TkDodo merged 2 commits into
TanStack:mainfrom
Hosuu:fix/page-size-validation-limit
Oct 26, 2026
Merged

TkDodo merged 2 commits into
TanStack:mainfrom
Hosuu:fix/page-size-validation-limit

Conversation

@Hosuu

@Hosuu Hosuu commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The page size selector on /showcase and /community-projects offers 24, 48, 96, 192, but pageSizeSchema in src/utils/schemas.ts only allows values up to 100 (v.maxValue(100)).

Picking 192 sets ?pageSize=192 in the URL, the search validation fails, and the page shows an error:

image

Reproduction

  1. Go to https://tanstack.com/showcase (or /community-projects)
  2. Change the page size to 192
  3. The page renders a validation error instead of results

Fix

Removed 192 from PAGE_SIZE_OPTIONS in both routes, so every option the UI offers passes validation:

  • src/routes/showcase/index.tsx
  • src/routes/community-projects.tsx

I kept the existing limit of 100 instead of raising it, since it probably protects the backend query size. Also, showing more than ~100 cards on one page already feels crowded, so 192 seems like more than users would need.

Summary by CodeRabbit

  • Updates
    • The community projects and showcase pages now offer page sizes of 24, 48, or 96 items; the 192-item option is no longer available.

@changeset-bot

changeset-bot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4de4986

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 69e4b4bb-924c-4d99-8db7-327c3208d7b9
Commits

Reviewing files that changed from the base of the PR and between 950c9cf and 4de4986.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b6bad43d-07a8-4801-94a3-a7e9386e27b5
📥 Commits

Reviewing files that changed from the base of the PR and between f192864 and 950c9cf.

📒 Files selected for processing: 2
  • src/routes/community-projects.tsx
  • src/routes/showcase/index.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The community projects and showcase routes remove 192 from their page size options. Both routes now offer 24, 48, and 96.

Changes: Page size options

Layer / File(s) Summary
Update route page size options
src/routes/community-projects.tsx, src/routes/showcase/index.tsx
Both routes remove 192 from PAGE_SIZE_OPTIONS. The remaining options are 24, 48, and 96.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: tannerlinsley, an1ndra

Merge Risk: Minimal · up to 950c9

The page-size options align with the validation limit, with no remaining merge-blocking risk identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: removing the unsupported page-size option so the UI matches the validation limit.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@harry-whorlow

Copy link
Copy Markdown
Contributor

@Hosuu, good catch. Thanks for the PR!

@TkDodo
TkDodo merged commit bccb7b7 into TanStack:main Oct 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants