Repository navigation
fix: allow boolean true in application starter tailwind search param - #1421
Conversation
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Accepting the parsed boolean makes sense, but the URL sync type needs a matching change before this can land. Can we keep the custom feature options typed as strings while allowing the boolean tailwind value?
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | fdb1321 | Commit Preview URL Branch Preview URL |
Oct 24 2026, 11:25 PM |
|
The updated type fixes the reported error. One correction to the earlier note: the store accepts unknown feature-option values, so there is no string-only setter contract to preserve.
|
TanStack Router JSON-parses URL search parameters, converting
?tailwind=trueinto the booleantrue. Previously, the valibot search schema only acceptedv.literal('false'), throwing a validation error whenever visitors arrived via URLs containingtailwind=true.Changes:
applicationStarterSearchSchemainsrc/routes/application-starter.index.tsxsotailwindacceptsv.union([v.literal('false'), v.literal(true)])ApplicationStarterSearchParamsinsrc/components/application-starter/useApplicationStarterUrl.tsto allowbooleanvalues on both thetailwindfield and the index signaturetests/application-starter-search.test.tsto accept{ tailwind: true }while continuing to reject{ tailwind: 'true' }Fixes TANSTACK-COM-5CJ
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.