Skip to content

fix: allow boolean true in application starter tailwind search param - #1421

Merged
tannerlinsley merged 2 commits into
mainfrom
seer/fix/application-starter-tailwind-param
Oct 24, 2026
Merged

tannerlinsley merged 2 commits into
mainfrom
seer/fix/application-starter-tailwind-param

Conversation

@sentry

@sentry sentry Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

TanStack Router JSON-parses URL search parameters, converting ?tailwind=true into the boolean true. Previously, the valibot search schema only accepted v.literal('false'), throwing a validation error whenever visitors arrived via URLs containing tailwind=true.

Changes:

  • Update applicationStarterSearchSchema in src/routes/application-starter.index.tsx so tailwind accepts v.union([v.literal('false'), v.literal(true)])
  • Update ApplicationStarterSearchParams in src/components/application-starter/useApplicationStarterUrl.ts to allow boolean values on both the tailwind field and the index signature
  • Update tests/application-starter-search.test.ts to accept { tailwind: true } while continuing to reject { tailwind: 'true' }

Fixes TANSTACK-COM-5CJ

@sentry <feedback>: Autofix iterates on these changes
@sentry stop iterating: Autofix stops iterating on this run

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@changeset-bot

changeset-bot Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fdb1321

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 22d7f790-e7c3-4a85-8abb-c794a130d13e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tannerlinsley

Copy link
Copy Markdown
Member

Accepting the parsed boolean makes sense, but the URL sync type needs a matching change before this can land. Can we keep the custom feature options typed as strings while allowing the boolean tailwind value?

AI review notes:
At af4beae15fd1a26f585a82862d4a4ba14e998616, ApplicationStarterSearchParams.tailwind includes true, but its string index signature still permits only string | undefined. An isolated TypeScript check of that interface reproduces TS2411. This is a focused type check, not a full application test.
Simply widening the index signature also affects the Object.entries(search) loop that passes values to setFeatureOption, so please preserve the string-only feature option contract there. The added schema test covers boolean true, but does not type-check this hook.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com fdb1321 Commit Preview URL

Branch Preview URL
Oct 24 2026, 11:25 PM

@tannerlinsley

Copy link
Copy Markdown
Member

The updated type fixes the reported error. One correction to the earlier note: the store accepts unknown feature-option values, so there is no string-only setter contract to preserve.

AI review notes:
At fdb1321f263e6f26f90fc53a3351027e311472bb, the extracted interface passes an isolated TypeScript check. Eight checks against the exact-head extracted schema pass, and the previous schema rejects boolean true as a negative control. All eight reported GitHub checks are green. These are focused checks, not an independent full application or original Sentry-session reproduction.

@tannerlinsley
tannerlinsley merged commit 8fc7b7a into main Oct 24, 2026
8 checks passed
@tannerlinsley
tannerlinsley deleted the seer/fix/application-starter-tailwind-param branch October 24, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant