Skip to content

USA 02 mission plays back behind main menu #3640

Open

Description

@xezon

USA 02 mission plays back behind the main menu. The USA 02 Intro video also does not load.

Repro:

  • Complete USA 01
  • Continue to USA 02
Image Image

Activity

  1. added theissue type on Nov 1, 2026
  2. added
    BugSomething is not working right, typically is user facing
    CriticalSeverity: Minor < Major < Critical < Blocker
    ZHRelates to Zero Hour
    ThisProjectThe issue was introduced by this project, or this task is specific to this project
    on Nov 1, 2026
  3. xezon commented on Nov 1, 2026

    @xezon
    Author

    I suspect a change to the Shell broke it.

  4. xezon commented on Nov 1, 2026

    @xezon
    Author

    Playing through GLA01 is probably quicker to test than USA01.

  5. gzhneo commented on Nov 1, 2026

    @gzhneo

    Does the error occur with or without retail compatibility?

    Core/GameEngine/Source/GameLogic/System/GameLogicDispatch.cpp

    #if !RETAIL_COMPATIBLE_CRC
    if ( isInGame() || isClearingGameData() || isLoadingMap() )
    {
    DEBUG_CRASH( ("Called MSG_NEW_GAME while game is not ready ...") );
    return false;
    }
    #endif

    My guess is that with #2440, you’ve uncovered an old EA bug. However, this only holds true if the issue occurs exclusively when retail compatibility is disabled. That would then require a small adjustment to Shell and ScoreScreen.

  6. xezon commented on Nov 1, 2026

    @xezon
    Author

    Right. I did test with RETAIL_COMPATIBLE_CRC (0)

  7. added
    NoRetailThis fix or change is not applicable with Retail game compatibility
    on Nov 1, 2026
  8. gzhneo commented on Nov 1, 2026

    @gzhneo

    I would add an optional bool parameter to popImmediate() in the file Core/GameEngine/Source/GameClient/GUI/Shell/Shell.cpp; that should solve the problem. then call this function from ScoreScreen.cpp, including the optional parameter. If you like, I can provide the code snippet for you and then you can test it.

  9. gzhneo commented on Nov 1, 2026

    @gzhneo

    This would allow you to distinguish between a true exit (returning to the main menu with the shell map) and proceeding to another mission (without the main menu or shell map).

  10. Caball009 commented on Nov 2, 2026

    @Caball009

    9. I would add an optional bool parameter to popImmediate() in the file Core/GameEngine/Source/GameClient/GUI/Shell/Shell.cpp; that should solve the problem. then call this function from ScoreScreen.cpp, including the optional parameter. If you like, I can provide the code snippet for you and then you can test it.

    If it's straightforward, go ahead and post it.

  11. gzhneo commented on Nov 8, 2026

    @gzhneo

    Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ScoreScreen.cpp (176-178)

    void startNextCampaignGame()
    {
    TheShell->popImmediate( FALSE );

    GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ScoreScreen.cpp (194-196)

    void startNextCampaignGame()
    {
    TheShell->popImmediate( FALSE );

    Core/GameEngine/Source/GameClient/GUI/Shell/Shell.cpp (441-478)

    //-------------------------------------------------------------------------------------------------
    /** When you need to immediately pop a screen off the stack use this method. It
    * gives the screen the opportunity to shutdown and tells the shutdown
    * method that an immediate pop is going to take place. When control returns
    * from the shutdown() for the screen, it will be immediately popped off
    * the stack */
    //-------------------------------------------------------------------------------------------------
    void Shell::popImmediate( Bool initUncoveredLayout )
    {
    WindowLayout *screen = top();
    ...
    // run the shutdown
    Bool immediatePop = TRUE;
    screen->runShutdown( &immediatePop );

        // pop the screen of the stack
        doPop( !initUncoveredLayout );
    
        if (TheIMEManager)
                TheIMEManager->detach();
    

    }

    Core/GameEngine/Include/GameClient/Shell.h (134)

    void popImmediate( Bool initUncoveredLayout = TRUE );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is not working right, typically is user facingCriticalSeverity: Minor < Major < Critical < BlockerNoRetailThis fix or change is not applicable with Retail game compatibilityThisProjectThe issue was introduced by this project, or this task is specific to this projectZHRelates to Zero Hour

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions