You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#if !RETAIL_COMPATIBLE_CRC
if ( isInGame() || isClearingGameData() || isLoadingMap() )
{
DEBUG_CRASH( ("Called MSG_NEW_GAME while game is not ready ...") );
return false;
}
#endif
My guess is that with #2440, you’ve uncovered an old EA bug. However, this only holds true if the issue occurs exclusively when retail compatibility is disabled. That would then require a small adjustment to Shell and ScoreScreen.
I would add an optional bool parameter to popImmediate() in the file Core/GameEngine/Source/GameClient/GUI/Shell/Shell.cpp; that should solve the problem. then call this function from ScoreScreen.cpp, including the optional parameter. If you like, I can provide the code snippet for you and then you can test it.
This would allow you to distinguish between a true exit (returning to the main menu with the shell map) and proceeding to another mission (without the main menu or shell map).
9. I would add an optional bool parameter to popImmediate() in the file Core/GameEngine/Source/GameClient/GUI/Shell/Shell.cpp; that should solve the problem. then call this function from ScoreScreen.cpp, including the optional parameter. If you like, I can provide the code snippet for you and then you can test it.
//-------------------------------------------------------------------------------------------------
/** When you need to immediately pop a screen off the stack use this method. It
* gives the screen the opportunity to shutdown and tells the shutdown
* method that an immediate pop is going to take place. When control returns
* from the shutdown() for the screen, it will be immediately popped off
* the stack */
//-------------------------------------------------------------------------------------------------
void Shell::popImmediate( Bool initUncoveredLayout )
{
WindowLayout *screen = top();
...
// run the shutdown
Bool immediatePop = TRUE;
screen->runShutdown( &immediatePop );
// pop the screen of the stack
doPop( !initUncoveredLayout );
if (TheIMEManager)
TheIMEManager->detach();
Activity
xezon commentedon Nov 1, 2026
I suspect a change to the Shell broke it.
xezon commentedon Nov 1, 2026
Playing through GLA01 is probably quicker to test than USA01.
gzhneo commentedon Nov 1, 2026
Does the error occur with or without retail compatibility?
Core/GameEngine/Source/GameLogic/System/GameLogicDispatch.cpp
#if !RETAIL_COMPATIBLE_CRC
if ( isInGame() || isClearingGameData() || isLoadingMap() )
{
DEBUG_CRASH( ("Called MSG_NEW_GAME while game is not ready ...") );
return false;
}
#endif
My guess is that with #2440, you’ve uncovered an old EA bug. However, this only holds true if the issue occurs exclusively when retail compatibility is disabled. That would then require a small adjustment to Shell and ScoreScreen.
xezon commentedon Nov 1, 2026
Right. I did test with RETAIL_COMPATIBLE_CRC (0)
gzhneo commentedon Nov 1, 2026
I would add an optional bool parameter to
popImmediate()in the fileCore/GameEngine/Source/GameClient/GUI/Shell/Shell.cpp; that should solve the problem. then call this function from ScoreScreen.cpp, including the optional parameter. If you like, I can provide the code snippet for you and then you can test it.gzhneo commentedon Nov 1, 2026
This would allow you to distinguish between a true exit (returning to the main menu with the shell map) and proceeding to another mission (without the main menu or shell map).
Caball009 commentedon Nov 2, 2026
If it's straightforward, go ahead and post it.
gzhneo commentedon Nov 8, 2026
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ScoreScreen.cpp (176-178)
void startNextCampaignGame()
{
TheShell->popImmediate( FALSE );
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ScoreScreen.cpp (194-196)
void startNextCampaignGame()
{
TheShell->popImmediate( FALSE );
Core/GameEngine/Source/GameClient/GUI/Shell/Shell.cpp (441-478)
//-------------------------------------------------------------------------------------------------
/** When you need to immediately pop a screen off the stack use this method. It
* gives the screen the opportunity to shutdown and tells the shutdown
* method that an immediate pop is going to take place. When control returns
* from the shutdown() for the screen, it will be immediately popped off
* the stack */
//-------------------------------------------------------------------------------------------------
void Shell::popImmediate( Bool initUncoveredLayout )
{
WindowLayout *screen = top();
...
// run the shutdown
Bool immediatePop = TRUE;
screen->runShutdown( &immediatePop );
}
Core/GameEngine/Include/GameClient/Shell.h (134)
void popImmediate( Bool initUncoveredLayout = TRUE );